Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bug when latitute/longitue are not provided #2533

Merged
merged 1 commit into from
May 15, 2018
Merged

fixed bug when latitute/longitue are not provided #2533

merged 1 commit into from
May 15, 2018

Conversation

harpere
Copy link
Collaborator

@harpere harpere commented May 14, 2018 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@idettman idettman self-requested a review May 15, 2018 00:20
idettman
idettman approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harpere harpere merged commit 6785bc5 into prebid:master May 15, 2018
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request May 15, 2018
Merge remote-tracking branch 'PreBid.js/master'
5c09f70 
* PreBid.js/master: (79 commits)
  increment prebid version
  Prebid 1.11.0 release
  replace find reference with imported version (prebid#2542)
  GDPR - add consent information to PBS cookie_sync request (prebid#2530)
  add support for safeframe workflow and new utils method to read adunit sizes (prebid#2523)
  Smart: GDPR support (prebid#2528)
  fix getPreparedBidForAuction to look for renderer on correct bid (prebid#2505)
  PubMatic Adapter: Bug fix to read all bids from seatBid array (prebid#2520)
  Create GXOne Bid Adapter and tests for it (prebid#2540)
  Lifestreet: gdpr and consent string parameters (prebid#2537)
  -GDPR support added in media net bidder (prebid#2538)
  change AppNexus endpoint to use ORTB (prebid#2532)
  fixed bug when latitute/longitue are not provided (prebid#2533)
  added gdpr support to userSync in rubicon adapter (prebid#2531)
  Show only summary and errors (prebid#2514)
  Aardvark v1.0 (prebid#2507)
  Add 1024x768 (size_id = 53) in sizeMap (prebid#2527)
  Add new Adapter brainyBidAdapter (prebid#2458)
  OpenX Adapter: GDPR Support (prebid#2504)
  add support for latLong in rubicon adapter (prebid#2508)
  ...
@robertrmartinez robertrmartinez deleted the rubicon-adapter-fix-latLong branch July 5, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harpere @idettman