Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rtbdemandAdkBidAdapter.js to rtbdemandadkBidAdapter.js #2553

Merged
merged 3 commits into from
May 28, 2018

Conversation

rtbdemand
Copy link
Contributor

@rtbdemand rtbdemand commented May 16, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@rtbdemand
Copy link
Contributor Author

Only updating Filename please change the same

@mkendall07
Copy link
Member

mkendall07 commented May 16, 2018

You got an error in the build because you also need to update ./test/spec/modules/rtbdemandAdkBidAdapter_spec.js to reference the new file name

@mkendall07
Copy link
Member

mkendall07 commented May 16, 2018

You need to make the changes in the same PR. Please don't open multiple PRs for a single change.

@rtbdemand
Copy link
Contributor Author

Made all changes in same PR

@mkendall07 mkendall07 self-assigned this May 16, 2018
@rtbdemand
Copy link
Contributor Author

Can you please merge this

@mkendall07 mkendall07 merged commit 3e8beb2 into prebid:master May 28, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
…#2553)

* Rename rtbdemandAdkBidAdapter.js to rtbdemandadkBidAdapter.js

* Update and rename rtbdemandAdkBidAdapter_spec.js to rtbdemandadkBidAdapter_spec.js

* Update and rename rtbdemandAdkBidAdapter.md to rtbdemandadkBidAdapter.md
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
…#2553)

* Rename rtbdemandAdkBidAdapter.js to rtbdemandadkBidAdapter.js

* Update and rename rtbdemandAdkBidAdapter_spec.js to rtbdemandadkBidAdapter_spec.js

* Update and rename rtbdemandAdkBidAdapter.md to rtbdemandadkBidAdapter.md
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
…#2553)

* Rename rtbdemandAdkBidAdapter.js to rtbdemandadkBidAdapter.js

* Update and rename rtbdemandAdkBidAdapter_spec.js to rtbdemandadkBidAdapter_spec.js

* Update and rename rtbdemandAdkBidAdapter.md to rtbdemandadkBidAdapter.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants