Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDPR support to DAN Marketplace Bid Adapter #2605

Merged
merged 9 commits into from
May 25, 2018

Conversation

danmarketplace
Copy link
Contributor

Type of change

  • Feature

Description of change

Added GDPR support to DAN Marketplace Bid Adapter

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@snapwich snapwich self-assigned this May 23, 2018
@snapwich
Copy link
Collaborator

There is a new third parameter to getUserSyncs that is the gdpr object. Does your pixel need to be updated to take into account gdpr compliance?

@danmarketplace
Copy link
Contributor Author

Thank you, we add gdpr parameters in our sync pixel.

@danmarketplace
Copy link
Contributor Author

Hey prebid team! @snapwich Any news on the review of this PR? BTW when are you going to release these changes?

@snapwich snapwich self-requested a review May 25, 2018 15:35
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 8c5f129 into prebid:master May 25, 2018
@snapwich
Copy link
Collaborator

@danmarketplace it should be released early next week as part of 1.13

Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
* Make Bid Adapter for Dentsu Aegis Network Marketplace

* Update DAN_Marketplace adapter

* Rename danmarketplaceBidAdapter into danmarketBidAdapter

* Add support of GDPR in DAN Marketplace Bid Adapter

* Add GDPR params in sync pixel
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Make Bid Adapter for Dentsu Aegis Network Marketplace

* Update DAN_Marketplace adapter

* Rename danmarketplaceBidAdapter into danmarketBidAdapter

* Add support of GDPR in DAN Marketplace Bid Adapter

* Add GDPR params in sync pixel
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Make Bid Adapter for Dentsu Aegis Network Marketplace

* Update DAN_Marketplace adapter

* Rename danmarketplaceBidAdapter into danmarketBidAdapter

* Add support of GDPR in DAN Marketplace Bid Adapter

* Add GDPR params in sync pixel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants