Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GDPR support for Quantum Adapter #2621

Merged
merged 29 commits into from
May 31, 2018
Merged

Add GDPR support for Quantum Adapter #2621

merged 29 commits into from
May 31, 2018

Conversation

sami-elasticad
Copy link
Contributor

  • Feature

Description of change

GDPR support for Quantum Adapter

  • contact email of the adapter’s maintainer
  • official adapter submission

Samuel Negru and others added 25 commits January 18, 2018 17:41
quantumBidAdapter initial commit
238ab74
eslint errors fixed
b18c512
Merge remote-tracking branch 'upstream/master'
c9136b8
updating quantumBidAdapter for reviews, fixed tests to work with native
56068a5
set new prebid location for testing and some fixing
d24543e
Merge remote-tracking branch 'remotes/upstream/master'
b5ad2b4
added supportedMediaTypes
0a69792
Tests fixed
535e20d
Fixed issues with image assets. Tested with the example provided
12f95cb
@photonx
Size and tests fixed
d655ebb
@photonx
Merge remote-tracking branch 'upstream/master'
5a96550 
# Conflicts:
#	integrationExamples/gpt/hello_world.html
#	modules/quantumBidAdapter.js
#	package.json
#	test/spec/modules/quantumBidAdapter_spec.js
@photonx
Modify tests
d99806e
@sami-elasticad
hello world revert changes
6f8fe02
@sami-elasticad
Merge remote-tracking branch 'upstream/master'
afa6cb2
@sami-elasticad
package-lock reverted
9b59f42
@sami-elasticad
hello world reverted CRLF/LF Conversion
e028cf6
@sami-elasticad
hello world reverted LF/CRLF Conversion
aed0363
@sami-elasticad
hello world reverted
9c2d313
@sami-elasticad
hello world reverted
2ecd6d2
@sami-elasticad
hello world reverted
769eb9f
@sami-elasticad
removed hardcoded bid sizes
04e13ae
@sami-elasticad
Merge remote-tracking branch 'upstream/master'
afdf32e
@sami-elasticad
GDPR integration
0022170
@sami-elasticad
Merge remote-tracking branch 'upstream/master'
dede438
@sami-elasticad
GDPR support - change quantx_gdpr to (0,1) values accepted
071a57a
@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta May 29, 2018
@snapwich snapwich self-requested a review May 29, 2018 20:14
snapwich
snapwich requested changes May 29, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be updating the package-lock.json file. Also, one of your tests should reflect the changes to the bidder request that now includes GDPR data.

@sami-elasticad
Copy link
Contributor Author

Please review changes. Thank you.

snapwich
snapwich approved these changes May 31, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 0519902 into prebid:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sami-elasticad @snapwich @ndhimehta @photonx