Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-app support in kumma adapter #2631

Merged
merged 1 commit into from
Jun 18, 2018
Merged

in-app support in kumma adapter #2631

merged 1 commit into from
Jun 18, 2018

Conversation

yehonatanshac
Copy link
Contributor

Type of change

  • Feature

Description of change

in-app support in kumma adapter

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#800

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yehonatanshac,

While I was trying to test out the changes for the new types, I was seeing some trouble with the request to the server providing a response. Each attempted request returned a 204 No Content response.

Can you take a look to see what might be the issue? Does anything look incorrect or malformed in the request objects?

Banner test request:

{"id":"1bbb05b5a999fc","at":2,"imp":[{"id":"2e25a3fefa98f4","secure":0,"banner":{"w":300,"h":250},"native":null,"video":null,"bidfloor":"0.000001","tagid":"123"}],"site":{"publisher":{"id":"29521","domain":"ap.localhost"},"id":"26049","ref":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","page":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"},"app":null,"device":{"dnt":0,"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36","language":"en-US","w":1680,"h":1050,"geo":{}}}

Video test request:

{"id":"15c728cdd1d28a","at":2,"imp":[{"id":"2d1137c8104518","secure":0,"banner":null,"native":null,"video":{"w":640,"h":480,"mimes":["video/mp4","video/webm","application/x-shockwave-flash","application/javascript"],"protocols":[2,3,5,6],"api":[1,2]},"bidfloor":"0.000001","tagid":"123"}],"site":{"publisher":{"id":"29521","domain":"ap.localhost"},"id":"26049","ref":"","page":"http://ap.localhost:9999/integrationExamples/gpt/video-instream-test.html?pbjs_debug=true"},"app":null,"device":{"dnt":0,"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36","language":"en-US","w":1680,"h":1050,"geo":{}}}

Native test request:

{"id":"1262722a48c241","at":2,"imp":[{"id":"2006a921e24299","secure":0,"banner":null,"native":{"request":"{\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":75}},{\"id\":2,\"required\":0,\"data\":{\"type\":2,\"len\":200}},{\"id\":4,\"required\":0,\"img\":{\"type\":1,\"wmin\":50,\"hmin\":50}},{\"id\":5,\"required\":1,\"img\":{\"type\":3,\"wmin\":150,\"hmin\":150}}]}","ver":"1.1"},"video":null,"bidfloor":"0.001","tagid":"123"}],"site":{"publisher":{"id":"29521","domain":"ap.localhost"},"id":"26047","ref":"","page":"http://ap.localhost:9999/integrationExamples/gpt/demo_native.html?pbjs_debug=true"},"app":null,"device":{"dnt":0,"ua":"Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Mobile Safari/537.36","language":"en-US","w":1785,"h":807,"geo":{"lat":"40.712775","lon":"-74.005973"},"ifa":"XXX-XXX"}}

@yehonatanshac
Copy link
Contributor Author

There was a problem in server side. It should work now.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yehonatanshac for making the fix. The bids are returning successfully now. LGTM

@jsnellbaker jsnellbaker merged commit d1e2ffa into prebid:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants