Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media.net Adapter Improvements Legacy #2635

Merged
merged 4 commits into from
Jun 11, 2018

Conversation

vedantseta
Copy link
Contributor

Type of change

  • Other

Description of change

This PR adds functionality adds slot visibility in request to bid optimally.

@vedantseta
Copy link
Contributor Author

@jaiminpanchal27 @ndhimehta can you please check what is the issue with this travis ci build?

@snapwich
Copy link
Collaborator

I restarted the tests; hopefully that works. Also, I left a comment on #2634 which also applies here. Let me know what you want to do.

@vedantseta
Copy link
Contributor Author

@snapwich can you please re run test cases?

@snapwich
Copy link
Collaborator

snapwich commented Jun 7, 2018

@vedantseta restarted. However, I think this pull-request requires the same treatment that #2634 received.

@vedantseta
Copy link
Contributor Author

@snapwich , can you please re run test cases and merge the same as #2634 is already merged ?

@snapwich snapwich self-requested a review June 11, 2018 16:52
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 17613b7 into prebid:legacy Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants