Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonobi - Fixed issue where consent_string param could be set as undefined #2656

Merged
merged 23 commits into from
Jun 1, 2018
Merged

Sonobi - Fixed issue where consent_string param could be set as undefined #2656

merged 23 commits into from
Jun 1, 2018

Conversation

JonGoSonobi
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Fixed issue where consent_string could be set as undefined

JonGoSonobi and others added 23 commits April 25, 2018 15:57
@JonGoSonobi
added vp param to trinity request
4f9d0a5
@JonGoSonobi
added lib_name and lib_v to trinity
d23114c
@JonGoSonobi
return null from buildRequests if there is no keymakers
ff5fabf
@JonGoSonobi
added test case for empty keymaker
ac246fd
@JonGoSonobi
only importing functions we need from utils
ef36be2
@JonGoSonobi
changed window.pbjs.version to use the gulp repalced macro .version$
85c9994
@JonGoSonobi
Merge branch 'master' into APEX-1472-vp
17bb578
@JonGoSonobi
resolved merge conflicts
82909d2
@JonGoSonobi
fixed issue where isEmpty was being called from old utils var. Change…
6c3e3a8 
…d test port expectations to the original 9876 port
@JonGoSonobi
fixed lint issue
cf45587
@JonGoSonobi
resolved merge conflict
fd54c1d
@JonGoSonobi
fixed issue where sonobi getUserSync was throwing an error on timeout
8898bf8
@JonGoSonobi
sonobi support referrer param
271e16d
@JonGoSonobi
Merge branch 'master' into APEX-1516-user-sync-timeout-err
7090d44
@JonGoSonobi
fixed unit test for testing the ref param on bid request
2f45786
@JonGoSonobi @bansawbanchee
return null from buildRequests if there is no keymakers
ffe0932
@JonGoSonobi @bansawbanchee
fixed issue where isEmpty was being called from old utils var. Change…
e0d53c1 
…d test port expectations to the original 9876 port
@bansawbanchee
Add gdpr support
4d7079a
@JonGoSonobi
resolved merge conflict
a55446c
@JonGoSonobi
Merge branch 'master' of https://github.com/prebid/Prebid.js
9bf2803
@JonGoSonobi
Merge branch 'master' of github.com:sonobi/Prebid.js
8f04800
@JonGoSonobi
Merge branch 'master' of https://github.com/prebid/Prebid.js
5124c39
@JonGoSonobi
only sending consent string if it exists
1ec4011
@jaiminpanchal27 jaiminpanchal27 self-assigned this Jun 1, 2018
@jaiminpanchal27 jaiminpanchal27 merged commit 2fb4878 into prebid:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonGoSonobi @jaiminpanchal27 @bansawbanchee