-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon Bid Adapter - ordered auction query params #2665
Merged
snapwich
merged 8 commits into
prebid:master
from
rubicon-project:HB-2447-order-ae-querystring-params
Jun 7, 2018
Merged
Rubicon Bid Adapter - ordered auction query params #2665
snapwich
merged 8 commits into
prebid:master
from
rubicon-project:HB-2447-order-ae-querystring-params
Jun 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* ordered ae query params * updated tg_v and tg_i filter strings * linting fix * extracted ordering code to a function * fixed param names for lat long * Added unit test to check AE param ordering * changed test for tg_i and tg_v * fix removed duplicated 'rf' in order params function
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* ordered ae query params * updated tg_v and tg_i filter strings * linting fix * extracted ordering code to a function * fixed param names for lat long * Added unit test to check AE param ordering * changed test for tg_i and tg_v * fix removed duplicated 'rf' in order params function
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* ordered ae query params * updated tg_v and tg_i filter strings * linting fix * extracted ordering code to a function * fixed param names for lat long * Added unit test to check AE param ordering * changed test for tg_i and tg_v * fix removed duplicated 'rf' in order params function
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* ordered ae query params * updated tg_v and tg_i filter strings * linting fix * extracted ordering code to a function * fixed param names for lat long * Added unit test to check AE param ordering * changed test for tg_i and tg_v * fix removed duplicated 'rf' in order params function
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* ordered ae query params * updated tg_v and tg_i filter strings * linting fix * extracted ordering code to a function * fixed param names for lat long * Added unit test to check AE param ordering * changed test for tg_i and tg_v * fix removed duplicated 'rf' in order params function
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* ordered ae query params * updated tg_v and tg_i filter strings * linting fix * extracted ordering code to a function * fixed param names for lat long * Added unit test to check AE param ordering * changed test for tg_i and tg_v * fix removed duplicated 'rf' in order params function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Rubicon Bid Adapter - ordered auction query params
2447