Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon Bid Adapter - ordered auction query params #2665

Merged

Conversation

idettman
Copy link
Contributor

@idettman idettman commented May 31, 2018

Type of change

  • Other

Description of change

Rubicon Bid Adapter - ordered auction query params

2447

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 1c53a2a into prebid:master Jun 7, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* ordered ae query params

* updated tg_v and tg_i filter strings

* linting fix

* extracted ordering code to a function

* fixed param names for lat long

* Added unit test to check AE param ordering

* changed test for tg_i and tg_v

* fix removed duplicated 'rf' in order params function
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* ordered ae query params

* updated tg_v and tg_i filter strings

* linting fix

* extracted ordering code to a function

* fixed param names for lat long

* Added unit test to check AE param ordering

* changed test for tg_i and tg_v

* fix removed duplicated 'rf' in order params function
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* ordered ae query params

* updated tg_v and tg_i filter strings

* linting fix

* extracted ordering code to a function

* fixed param names for lat long

* Added unit test to check AE param ordering

* changed test for tg_i and tg_v

* fix removed duplicated 'rf' in order params function
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* ordered ae query params

* updated tg_v and tg_i filter strings

* linting fix

* extracted ordering code to a function

* fixed param names for lat long

* Added unit test to check AE param ordering

* changed test for tg_i and tg_v

* fix removed duplicated 'rf' in order params function
@idettman idettman deleted the HB-2447-order-ae-querystring-params branch February 5, 2019 00:04
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* ordered ae query params

* updated tg_v and tg_i filter strings

* linting fix

* extracted ordering code to a function

* fixed param names for lat long

* Added unit test to check AE param ordering

* changed test for tg_i and tg_v

* fix removed duplicated 'rf' in order params function
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* ordered ae query params

* updated tg_v and tg_i filter strings

* linting fix

* extracted ordering code to a function

* fixed param names for lat long

* Added unit test to check AE param ordering

* changed test for tg_i and tg_v

* fix removed duplicated 'rf' in order params function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants