Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTopWindowUrl #2673

Merged
merged 6 commits into from
Jun 7, 2018
Merged

Fix getTopWindowUrl #2673

merged 6 commits into from
Jun 7, 2018

Conversation

AntoineJac
Copy link
Contributor

@AntoineJac AntoineJac commented Jun 4, 2018

getTopWindowUrl error, it should be exports.function not this.function

FB adapter is relying on this for getting the top location and for Postbid in Safeframe the referer is not passed. exports.getTopWindowLocation() should be used if this.getTopWindowLocation is not defined.

The FB JS test is made so pagueUrl must be void instead of returning the page (localhost for) or url format. That is why I was forced to do if (href.search(‘localhost/?‘) > 0) { href = ‘’; }

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Antoine Jacquemin (Rubicon) added 2 commits June 4, 2018 16:44
getTopWindowUrl error, it should be exports.function not this.function
Fix to pass FB test
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand these changes. Is it just a FB test that needs this? or is there a real production problem? And under what circumstances does exports.getTopWindowLocation() work, but not this..getTopWindowLocation()?

@AntoineJac
Copy link
Contributor Author

As discussed I have edited to the correct behaviour and edit some change on Karma test for AudienceNetwork adapter.
@AudienceNetwork could you please review?
Thanks,

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harpere harpere added needs 2nd review Core module updates require two approvals from the core team LGTM labels Jun 7, 2018
@harpere harpere assigned jaiminpanchal27 and unassigned harpere Jun 7, 2018
@jaiminpanchal27 jaiminpanchal27 merged commit f7f0707 into prebid:master Jun 7, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Fix getTopWindowUrl

getTopWindowUrl error, it should be exports.function not this.function

* Update utils.js

Fix to pass FB test

* Update audienceNetworkBidAdapter_spec.js

* Update utils.js

* Update utils.js

* Update utils.js
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* Fix getTopWindowUrl

getTopWindowUrl error, it should be exports.function not this.function

* Update utils.js

Fix to pass FB test

* Update audienceNetworkBidAdapter_spec.js

* Update utils.js

* Update utils.js

* Update utils.js
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* Fix getTopWindowUrl

getTopWindowUrl error, it should be exports.function not this.function

* Update utils.js

Fix to pass FB test

* Update audienceNetworkBidAdapter_spec.js

* Update utils.js

* Update utils.js

* Update utils.js
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Fix getTopWindowUrl

getTopWindowUrl error, it should be exports.function not this.function

* Update utils.js

Fix to pass FB test

* Update audienceNetworkBidAdapter_spec.js

* Update utils.js

* Update utils.js

* Update utils.js
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* Fix getTopWindowUrl

getTopWindowUrl error, it should be exports.function not this.function

* Update utils.js

Fix to pass FB test

* Update audienceNetworkBidAdapter_spec.js

* Update utils.js

* Update utils.js

* Update utils.js
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* Fix getTopWindowUrl

getTopWindowUrl error, it should be exports.function not this.function

* Update utils.js

Fix to pass FB test

* Update audienceNetworkBidAdapter_spec.js

* Update utils.js

* Update utils.js

* Update utils.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM needs review needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants