Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native images bug fixed #2681

Merged
merged 31 commits into from
Jun 6, 2018
Merged

Native images bug fixed #2681

merged 31 commits into from
Jun 6, 2018

Conversation

sami-elasticad
Copy link
Contributor

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

  • contact email of the adapter’s maintainer

  • official adapter submission

@jsnellbaker jsnellbaker self-assigned this Jun 6, 2018
@jsnellbaker jsnellbaker self-requested a review June 6, 2018 12:36
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit ee4074e into prebid:master Jun 6, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants