-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Prebid Analytics by Roxot #2688
Refactoring Prebid Analytics by Roxot #2688
Conversation
This pull request fixes 1 alert when merging 7a6fc76 into ee4074e - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit to remove a bunch of the adaptermanager stuff (it's unnecessary and clutters up the tests). Other than that, LGTM.
c5675a2
to
df66ba1
Compare
This pull request fixes 1 alert when merging df66ba1 into 1646c0b - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
* Refactoring Prebid Analytics by Roxot * remove adaptermanager from analytics adapter tests
* Refactoring Prebid Analytics by Roxot * remove adaptermanager from analytics adapter tests
* Refactoring Prebid Analytics by Roxot * remove adaptermanager from analytics adapter tests
* Refactoring Prebid Analytics by Roxot * remove adaptermanager from analytics adapter tests
* Refactoring Prebid Analytics by Roxot * remove adaptermanager from analytics adapter tests
Type of change
Description of change
Big refactoring Analytics Adapter by Roxot