Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just Premium: add format parameter (issue #2691) #2693

Merged
merged 48 commits into from
Jun 11, 2018

Conversation

nwlosinski
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added parameter 'format' to bidResponse object.

Other information

Regarding to issue #2691

Copy link
Collaborator

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ Thanks for the quick addition.

@jsnellbaker jsnellbaker requested review from mike-chowla and removed request for jaiminpanchal27 June 7, 2018 16:30
@mike-chowla mike-chowla changed the title Feature/issue 2691 Just Premium: add format parameter (issue #2691) Jun 11, 2018
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 0bad407 into prebid:master Jun 11, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants