Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New optional bid parameter #2694

Merged
merged 19 commits into from
Jun 7, 2018
Merged

New optional bid parameter #2694

merged 19 commits into from
Jun 7, 2018

Conversation

rade-popovic
Copy link
Contributor

@rade-popovic rade-popovic commented Jun 7, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

@snapwich snapwich merged commit 0885ae0 into prebid:master Jun 7, 2018
@snapwich snapwich self-requested a review June 7, 2018 21:40
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rade-popovic
Copy link
Contributor Author

Thanks for quick review!

dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants