check if bidder exists before making request object #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsnellbaker Pulled this branch and confirmed it fixes #2677. Thanks! |
mkendall07
reviewed
Jun 13, 2018
There was a problem hiding this comment.
This LGTM but why do we have 2 places we are checking this / giving an error message:
https://github.com/prebid/Prebid.js/blob/master/src/adaptermanager.js#L352
|
@mkendall07 I removed the redundant check in the |
jsnellbaker
added
needs 2nd review
jaiminpanchal27
approved these changes
Jun 18, 2018
jaiminpanchal27
added
LGTM
and removed
needs 2nd review
|
@jsnellbaker this has conflicts that need to be resolved. |
|
@harpere the conflict should be resolved now. |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* check if bidder exists before making request object * remove redundant check
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* check if bidder exists before making request object * remove redundant check
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* check if bidder exists before making request object * remove redundant check
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* check if bidder exists before making request object * remove redundant check
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* check if bidder exists before making request object * remove redundant check
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* check if bidder exists before making request object * remove redundant check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
To fix the issue #2677
Currently when an invalid/unknown bidder is used in an auction, a request object is still made for that bidder. When the auction is running, it will recognize the bidder wasn't real and would return an error. But the
donerelated code used latter in the auction would still try to wait for that bidder's request to respond causing the auction to wait for the timeout.This fix performs the check to validate the bidder earlier, and if the bidder is rejected then the request object doesn't get made. This streamlines the latter logic to only wait for bidders that are real/registered.