Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground xyz - GDPR integration. #2699

Merged
merged 44 commits into from
Jun 18, 2018
Merged

Conversation

teranchristian
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added GDPR integration.
Added tests for GDPR integration.

  • test parameters for validating bids
 {
      code: 'ad-unit-1',
      sizes: [[320, 50], [300, 250]],
      bids: [
        {
          bidder: 'playgroundxyz',
          params: {
            placementId: '12913056',           
         }
        }
      ]
    }

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

teranchristian and others added 30 commits October 18, 2017 15:09
change application type to application\json for playground adapter
@jsnellbaker jsnellbaker self-assigned this Jun 8, 2018
@jsnellbaker jsnellbaker self-requested a review June 8, 2018 12:29
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teranchristian These adapter changes LGTM.

Just need you to open a docs PR in the docs repo and make an update in your bidders page to add the following variable.

gdpr_supported: true

This can go directly below the variable for your 1.0 compliance. This will allow your adapter to appear in a table that shows GDPR compliant adapters.

Thanks!

@jsnellbaker jsnellbaker merged commit c739338 into prebid:master Jun 18, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* add playground adapters

* clean up

* update with upstream master

* add test file clean up adapter by removing native referecnes

* test file

* replace appnexus with playground reference in error logs

* remove commented code

* change key in response object from appnexus to playgroundxyz

* change tests so we test for ordering by cpm as well

* dont drop other bids, just set cpm to 0 and send it through

* clean up

* restore glulp file

* fix documentation

* remove cpm logic from adapter

* change application type to application\json for playground adapter

* update adaptor to use openRtb

* add device and site to bid

* add extra space on error msg

* remove package-lock

* update pg details

* Update playgroundxyzBidAdapter.md

* add GDPR
remove video sample config form .md file
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* add playground adapters

* clean up

* update with upstream master

* add test file clean up adapter by removing native referecnes

* test file

* replace appnexus with playground reference in error logs

* remove commented code

* change key in response object from appnexus to playgroundxyz

* change tests so we test for ordering by cpm as well

* dont drop other bids, just set cpm to 0 and send it through

* clean up

* restore glulp file

* fix documentation

* remove cpm logic from adapter

* change application type to application\json for playground adapter

* update adaptor to use openRtb

* add device and site to bid

* add extra space on error msg

* remove package-lock

* update pg details

* Update playgroundxyzBidAdapter.md

* add GDPR
remove video sample config form .md file
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* add playground adapters

* clean up

* update with upstream master

* add test file clean up adapter by removing native referecnes

* test file

* replace appnexus with playground reference in error logs

* remove commented code

* change key in response object from appnexus to playgroundxyz

* change tests so we test for ordering by cpm as well

* dont drop other bids, just set cpm to 0 and send it through

* clean up

* restore glulp file

* fix documentation

* remove cpm logic from adapter

* change application type to application\json for playground adapter

* update adaptor to use openRtb

* add device and site to bid

* add extra space on error msg

* remove package-lock

* update pg details

* Update playgroundxyzBidAdapter.md

* add GDPR
remove video sample config form .md file
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* add playground adapters

* clean up

* update with upstream master

* add test file clean up adapter by removing native referecnes

* test file

* replace appnexus with playground reference in error logs

* remove commented code

* change key in response object from appnexus to playgroundxyz

* change tests so we test for ordering by cpm as well

* dont drop other bids, just set cpm to 0 and send it through

* clean up

* restore glulp file

* fix documentation

* remove cpm logic from adapter

* change application type to application\json for playground adapter

* update adaptor to use openRtb

* add device and site to bid

* add extra space on error msg

* remove package-lock

* update pg details

* Update playgroundxyzBidAdapter.md

* add GDPR
remove video sample config form .md file
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* add playground adapters

* clean up

* update with upstream master

* add test file clean up adapter by removing native referecnes

* test file

* replace appnexus with playground reference in error logs

* remove commented code

* change key in response object from appnexus to playgroundxyz

* change tests so we test for ordering by cpm as well

* dont drop other bids, just set cpm to 0 and send it through

* clean up

* restore glulp file

* fix documentation

* remove cpm logic from adapter

* change application type to application\json for playground adapter

* update adaptor to use openRtb

* add device and site to bid

* add extra space on error msg

* remove package-lock

* update pg details

* Update playgroundxyzBidAdapter.md

* add GDPR
remove video sample config form .md file
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* add playground adapters

* clean up

* update with upstream master

* add test file clean up adapter by removing native referecnes

* test file

* replace appnexus with playground reference in error logs

* remove commented code

* change key in response object from appnexus to playgroundxyz

* change tests so we test for ordering by cpm as well

* dont drop other bids, just set cpm to 0 and send it through

* clean up

* restore glulp file

* fix documentation

* remove cpm logic from adapter

* change application type to application\json for playground adapter

* update adaptor to use openRtb

* add device and site to bid

* add extra space on error msg

* remove package-lock

* update pg details

* Update playgroundxyzBidAdapter.md

* add GDPR
remove video sample config form .md file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants