Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAdservertargeting fix #2702

Merged
merged 1 commit into from
Jun 18, 2018
Merged

getAdservertargeting fix #2702

merged 1 commit into from
Jun 18, 2018

Conversation

jaiminpanchal27
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This function was including all the older rendered bids as well as expired bids from bid pool.

@bretg bretg requested a review from snapwich June 11, 2018 15:10
snapwich
snapwich approved these changes Jun 11, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derdeka
derdeka approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@derdeka derdeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit c82572e into master Jun 18, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@jaiminpanchal27 @dluxemburg
getAdservertargeting fix (prebid#2702)
88fc3f3
@mkendall07 mkendall07 deleted the getAdservertargeting-bugfix branch August 17, 2018 15:13
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
@jaiminpanchal27 @florevallatmrf
getAdservertargeting fix (prebid#2702)
cc85aa5
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
@jaiminpanchal27 @StefanWallin
getAdservertargeting fix (prebid#2702)
a6f3f5a
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@jaiminpanchal27
getAdservertargeting fix (prebid#2702)
e11be2b
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@jaiminpanchal27 @AlessandroDG
getAdservertargeting fix (prebid#2702)
7c645ba
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@jaiminpanchal27 @AlessandroDG
getAdservertargeting fix (prebid#2702)
03df9c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derdeka derdeka derdeka approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaiminpanchal27 @snapwich @mkendall07 @derdeka