move generation of transactionIds to requestBids over addAdUnits #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
added
the
needs 2nd review
mike-chowla
removed
the
needs 2nd review
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…bid#2706) * move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
…bid#2706) * move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…bid#2706) * move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
9 tasks
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…bid#2706) * move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…bid#2706) * move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…bid#2706) * move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Currently the
transactionIdis generation inaddAdUnits. This means adUnits created and passed torequestBidsmanually will not have atransactionIds (unless they add them manually). It probably makes more sense forrequestBidsto add thetransactionIds to the objects if they don't already exist.