-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fyber Bid Adapter #2709
Fyber Bid Adapter #2709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review:
http://prebid.org/dev-docs/bidder-adaptor.html
modules/fyberBidAdapter.js
Outdated
} | ||
|
||
if (typeof $$PREBID_GLOBAL$$ !== 'undefined') { | ||
toQueryString.bco = $$PREBID_GLOBAL$$.cbTimeout || $$PREBID_GLOBAL$$.bidderTimeout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapters are not permitted to reference
modules/fyberBidAdapter.js
Outdated
* @param urls: Array<String> | ||
*/ | ||
fire(urls) { | ||
urls.forEach(url => url && ((new Image(1, 1)).src = encodeURI(url))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapters are not permitted to create their own tracking pixels. If you want to fire a pixel, return it from getUserSyncs()
@mike-chowla, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-chowla, we've made changes based on your review. Is there something more we need to do from our side to proceed with the pull request?
Type of change
Description of change
New Bid Adapter for Fyber (https://www.fyber.com)
Be sure to test the integration with your adserver using the Hello World sample page.
uri@inner-active.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Link to documentation:
prebid/prebid.github.io#830