Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyber Bid Adapter #2709

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Fyber Bid Adapter #2709

merged 4 commits into from
Jun 18, 2018

Conversation

uriw-fyber
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • [ X] New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

New Bid Adapter for Fyber (https://www.fyber.com)

  • test parameters for validating bids
{
  bidder: 'fyber',
    params: {
        APP_ID: 'MyCompany_MyApp',
        spotType: 'rectangle',
        customParams: {
            portal: 7002
        }
    }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#830

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

if (typeof $$PREBID_GLOBAL$$ !== 'undefined') {
toQueryString.bco = $$PREBID_GLOBAL$$.cbTimeout || $$PREBID_GLOBAL$$.bidderTimeout;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapters are not permitted to reference $$PREBID_GLOBAL$$

* @param urls: Array<String>
*/
fire(urls) {
urls.forEach(url => url && ((new Image(1, 1)).src = encodeURI(url)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapters are not permitted to create their own tracking pixels. If you want to fire a pixel, return it from getUserSyncs()

@uriw-fyber
Copy link
Contributor Author

@mike-chowla, thanks.
We removed the tracking pixels and are not accessing the $$PREBID_GLOBAL$$ variable

Copy link
Contributor Author

@uriw-fyber uriw-fyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike-chowla, we've made changes based on your review. Is there something more we need to do from our side to proceed with the pull request?

@mike-chowla mike-chowla merged commit 618358b into prebid:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants