Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weborama header bidding adapter 1.0.0 #2710

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Weborama header bidding adapter 1.0.0 #2710

merged 1 commit into from
Jun 21, 2018

Conversation

devweborama
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add adapter and tests for the Weborama header bidding adapter

  • test parameters for validating bids
{
   bidder: 'weborama',
   params: {
      placementId: 0,
      traffic: 'banner'
    }
}

@devweborama
Copy link
Contributor Author

Docs: prebid/prebid.github.io#831

@bretg bretg requested a review from idettman June 11, 2018 15:27
@ndhimehta ndhimehta assigned snapwich and unassigned idettman Jun 12, 2018
snapwich
snapwich approved these changes Jun 21, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 7e53e83 into prebid:master Jun 21, 2018
@devweborama devweborama mentioned this pull request Jul 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

@idettman idettman Awaiting requested review from idettman

Assignees

@snapwich snapwich

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devweborama @snapwich @idettman @harpere