move logic to check if CMP is not found #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
added
needs review
needs 2nd review
mkendall07
approved these changes
Jun 21, 2018
snapwich
removed
the
needs 2nd review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
To address the issue reported in #2714
With the old logic, the consentManagement module would go through part of the iframe workflow to detect if the CMP locator frame was not found. While this code was part of the IAB spec for the CMP, in our case it meant that a local version of the
window.__cmpfunction was still created in a page where a normal CMP doesn't exist (which was the issue that was reported).This fix moves the check that ultimately detects if the CMP locator frame is present so that it's outside the iframe function in order to prevent creating the
window.__cmpfunction) while still throwing an error.