update consentManagement error logic/handling #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent!! I will give it a try. |
jsnellbaker
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix for #2720
This change will skip the check to evaluate the CMP results if the
gdprAppliesfield is set tofalse. This change is meant to support CMP's that will not collect any consent information for any non-EU end-users; their response in this scenario would begdprApplies=falseandnullfor any other consent fields.This change also updates the error message to better present the CMP response in the console. Previously the
consentObjectin the log message would just show [Object object] instead of the actual object.