Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My6sense new adapter #2748

Merged
merged 7 commits into from
Jul 10, 2018
Merged

My6sense new adapter #2748

merged 7 commits into from
Jul 10, 2018

Conversation

my6sense
Copy link
Contributor

@my6sense my6sense commented Jun 20, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

First push for new adapter

  • test parameters for validating bids
{
  bidder: 'my6sense',
  params: {    
    key: 'mW3mLht0kMT',
    pageUrl: '[PAGE_URL]',
    zone: '[ZONE]',
    dataView: ''
    organicClicks:'',
    paidClicks:''
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg
Copy link
Collaborator

bretg commented Jun 21, 2018

Docs PR is prebid/prebid.github.io#846

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as how your endpoint is returning an object that is directly used as the bid, it would be a good idea to include a version in end point url.

@@ -0,0 +1,194 @@
const {registerBidder} = require('../src/adapters/bidderFactory');
const BIDDER_CODE = 'my6sense';
const END_POINT = 'http://papi.mynativeplatform.com/pub2/web/hbwidget.json';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapter does not support https which is required

@my6sense
Copy link
Contributor Author

@mike-chowla - we added a version number to the endpoint url and removed the "http" from the url it self and now it starts with // to make sure we support ssl as well.

@my6sense
Copy link
Contributor Author

my6sense commented Jul 2, 2018

@mike-chowla, we made the changes and pushed them a week ago.
is there anything else we need to do?

@mike-chowla
Copy link
Contributor

@my6sense Apologies for the delay.

Question: I don't see your adapter declaring supportedMediaTypes which I believe means you'll only be bidding manner. I looked at your doc PR which list supported media type as native.

Are you intending to bid on banner, banner & native, or just native?

@my6sense
Copy link
Contributor Author

my6sense commented Jul 9, 2018

@mike-chowla, i just added the "supportedMediaTypes" property to the spec object, we are using BANNER & NATIVE types, thanks.

@mike-chowla
Copy link
Contributor

I'm not getting bids back due to a CORS error.

screen shot 2018-07-09 at 11 34 16 am

@my6sense
Copy link
Contributor Author

@mike-chowla, i updated our my6senseBidAdapter.md file with a valid widget key "OAJJBW2LRYi2CxfhzqogkA", please re-check it.
thanks

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 8010d07 into prebid:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants