-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My6sense new adapter #2748
My6sense new adapter #2748
Conversation
Docs PR is prebid/prebid.github.io#846 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as how your endpoint is returning an object that is directly used as the bid, it would be a good idea to include a version in end point url.
modules/my6senseBidAdapter.js
Outdated
@@ -0,0 +1,194 @@ | |||
const {registerBidder} = require('../src/adapters/bidderFactory'); | |||
const BIDDER_CODE = 'my6sense'; | |||
const END_POINT = 'http://papi.mynativeplatform.com/pub2/web/hbwidget.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapter does not support https which is required
@mike-chowla - we added a version number to the endpoint url and removed the "http" from the url it self and now it starts with // to make sure we support ssl as well. |
@mike-chowla, we made the changes and pushed them a week ago. |
@my6sense Apologies for the delay. Question: I don't see your adapter declaring supportedMediaTypes which I believe means you'll only be bidding manner. I looked at your doc PR which list supported media type as native. Are you intending to bid on banner, banner & native, or just native? |
@mike-chowla, i just added the "supportedMediaTypes" property to the spec object, we are using BANNER & NATIVE types, thanks. |
@mike-chowla, i updated our my6senseBidAdapter.md file with a valid widget key "OAJJBW2LRYi2CxfhzqogkA", please re-check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
First push for new adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information