Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user sync to Beachfront adapter #2761

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

jsalis
Copy link
Contributor

@jsalis jsalis commented Jun 21, 2018

Type of change

  • Feature

Description of change

Adds user sync support to the Beachfront adapter.

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but one question.

.forEach(bid => {
syncs.push({
type: 'iframe',
url: bid.sync
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not adding gdpr params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gdpr params will be added by the server in this case.

@harpere harpere self-assigned this Jun 22, 2018
@harpere harpere added LGTM and removed needs review labels Jun 22, 2018
@harpere harpere merged commit 415926a into prebid:master Jun 22, 2018
@jsalis jsalis deleted the support-user-sync branch July 2, 2018 16:22
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants