Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support to clickforce adapter #2776

Merged
merged 9 commits into from
Jul 30, 2018
Merged

Add native support to clickforce adapter #2776

merged 9 commits into from
Jul 30, 2018

Conversation

MIGOdanis
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

New bidder adapter from clickforce

  • test parameters for validating bids (display ad)
{
  bidder: "clickforce",
  params: {
      zone: "6682",
  }
}
  • test parameters for validating bids (native ad)
{
  bidder: "clickforce",
  params: {
      zone: "6878",
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MIGOdanis
Copy link
Contributor Author

@mjacobsonny Hi can you let me know what doc we need? thank you very much

@mjacobsonny
Copy link

@MIGOdanis
Copy link
Contributor Author

@mjacobsonny hi, Thanks for the help. we are add media_types now.

@stale
Copy link

stale bot commented Jul 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Jul 30, 2018
@MIGOdanis
Copy link
Contributor Author

MIGOdanis commented Jul 30, 2018

hi @mjacobsonny

if we need do anything. please let me know.

thanks!

@snapwich snapwich merged commit 1fc8d34 into prebid:master Jul 30, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* add getUserSyncs function

* bug fix

* add test spec

* fix of docment format

* fix of end line

* add getUserSyncs function into test file and updated test parameters

* add native ad

* update md doc
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* add getUserSyncs function

* bug fix

* add test spec

* fix of docment format

* fix of end line

* add getUserSyncs function into test file and updated test parameters

* add native ad

* update md doc
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* add getUserSyncs function

* bug fix

* add test spec

* fix of docment format

* fix of end line

* add getUserSyncs function into test file and updated test parameters

* add native ad

* update md doc
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* add getUserSyncs function

* bug fix

* add test spec

* fix of docment format

* fix of end line

* add getUserSyncs function into test file and updated test parameters

* add native ad

* update md doc
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* add getUserSyncs function

* bug fix

* add test spec

* fix of docment format

* fix of end line

* add getUserSyncs function into test file and updated test parameters

* add native ad

* update md doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants