Sharethrough: Handle iframeSize parameter to allow Pub to explicitly call out the size #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-chowla
changed the title
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…ize (prebid#2782) we render in
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
…ize (prebid#2782) we render in
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…ize (prebid#2782) we render in
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…ize (prebid#2782) we render in
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…ize (prebid#2782) we render in
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…ize (prebid#2782) we render in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Allow the Publisher to explicitly call out which size we should render in with the
iframeSizeparameter, if omitted we'll fall back to the largest size (by area). This parameter is ignored if theiframeparameter is omitted or false.Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
jchau@sharethrough.com cpan@sharethrough.com cnguyen@sharethrough.com
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Update documentation for Sharethrough prebid.github.io#863
Other information
@chriscpan @lestopher