ServerBid: Fixing adserver trying to get bidder name from params #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-chowla
requested changes
Jul 3, 2018
package-lock.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "prebid.js", | |||
| "version": "1.15.0-pre", | |||
There was a problem hiding this comment.
Please remove the change to package-lock.json
Saigredan
force-pushed
the
serverbid_param_fix
branch
from
fd7f520 to
dcb4003
Compare
|
@mike-chowla Change has been made as requested |
mike-chowla
changed the title
mike-chowla
approved these changes
Jul 5, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When creating userSync URL, serverbid adapter is trying to set bidder name based on params object which is wrong according to documentation and general logic. This problematic especially with connectad alias, which has its own url for userSync when iframeEnabled is true.