Fix rubicon video playersize issue #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase off master prebid
…rom the inside array
snapwich
requested changes
Jun 28, 2018
modules/rubiconBidAdapter.js
Outdated
| @@ -532,7 +532,7 @@ function parseSizes(bid) { | |||
| if (hasVideoMediaType(bid)) { | |||
| let size = []; | |||
| if (typeof utils.deepAccess(bid, 'mediaTypes.video.playerSize') !== 'undefined') { | |||
There was a problem hiding this comment.
If we are expecting an array this should be changed to check result with Array.isArray
There was a problem hiding this comment.
You are right, will add that checking
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* video player size is always doublely wrapped, need to read the size from the inside array * switch priorities and add checking for array
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* video player size is always doublely wrapped, need to read the size from the inside array * switch priorities and add checking for array
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* video player size is always doublely wrapped, need to read the size from the inside array * switch priorities and add checking for array
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* video player size is always doublely wrapped, need to read the size from the inside array * switch priorities and add checking for array
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* video player size is always doublely wrapped, need to read the size from the inside array * switch priorities and add checking for array
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* video player size is always doublely wrapped, need to read the size from the inside array * switch priorities and add checking for array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
video player size is always doubly wrapped, which means it's always an array of size array, need to read size from the inside array