-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBS Adapter: call done when ajax request fails #2794
Conversation
modules/prebidServerBidAdapter.js
Outdated
response => handleResponse(response, requestedBidders, bidRequests, addBidResponse, done), | ||
{ | ||
success: response => handleResponse(response, requestedBidders, bidRequests, addBidResponse, done), | ||
error: () => { done(); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this error be logged somewhere, so it shows up in debug mode?
If not: error: done
should work here. No need to wrap the function in another function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* call done when ajax request fails * no need to wrap function here
* call done when ajax request fails * no need to wrap function here
* call done when ajax request fails * no need to wrap function here
* call done when ajax request fails * no need to wrap function here
* call done when ajax request fails * no need to wrap function here
* call done when ajax request fails * no need to wrap function here
Type of change
Description of change
PBS adapter was not calling done when ajax requests fails. done not getting called means auction will not close if all other bidders are back before timeout.