Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etargetse patch 1 #2811

Merged
merged 18 commits into from
Jul 30, 2018
Merged

Etargetse patch 1 #2811

merged 18 commits into from
Jul 30, 2018

Conversation

etargetse
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'etarget',
  params: {
      refid: 56082,
      country: 1
  }
}

@stale
Copy link

stale bot commented Jul 17, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 17, 2018
@bretg bretg removed the stale label Jul 18, 2018
@bretg
Copy link
Collaborator

bretg commented Jul 18, 2018

associated with docs PR prebid/prebid.github.io#892

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but there are no unit tests. Create a file at the following path test/spec/modules/etargetBidAdapter_spec.js to contain the unit tests.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 2eb77d0 into prebid:master Jul 30, 2018
@bretg
Copy link
Collaborator

bretg commented Aug 2, 2018

released with 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants