additional parameters sent on auction, impression and video level #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Jul 13, 2018
| const simpleVideo = JSON.parse(JSON.stringify(bidVideo)) | ||
| simpleVideo.params.adzoneid = 123 | ||
| expect(spec.isBidRequestValid(simpleVideo)).to.be.false | ||
| // simpleVideo.params.site_id = siteId; |
There was a problem hiding this comment.
Remove commented code here, line 64 and line 85
There was a problem hiding this comment.
Can you also delete line 59
jaiminpanchal27
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added additional parameters that are sent in bidrequest on auction, impression and video level
info@adxcg.com