C1X Adapter GDPR Support #2821
Merged
C1X Adapter GDPR Support #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also sent a PR to update our doc on Prebid website |
mike-chowla
requested changes
Jul 5, 2018
modules/c1xBidAdapter.js
Outdated
|
|
||
| let payloadString = stringifyPayload(payload); | ||
| if (pixelId) { |
There was a problem hiding this comment.
Why is there sync added here, when the sync is also added on line 59? Adding two syncs seems wasteful.
|
@mike-chowla Thanks for pointing that out. I only intended to do one sync but forgot deleting the old codes. I have updated the code and ensure there is only one user sync. |
|
@mike-chowla Please help to review the change and let me know if you have any questions. Thank you! |
mike-chowla
approved these changes
Jul 24, 2018
|
@CathyHuangtw Please create a doc PR to update that your adapter now supports GDPR consent passing |
|
@mike-chowla Thanks for your review. |
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding GDPR support to C1X adapter
contact email of the adapter’s maintainer
cathy@c1exchange.com