Add Sortable bid adapter

[shannonAB]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Add the Sortable bidder adapter.

• test parameters for validating bids

var adUnits = [
  {
    code: 'test-pb-leaderboard',
    sizes: [[728, 90]],
    bids: [{
      bidder: 'sortable',
      params: {
        tagId: 'test-pb-leaderboard',
        siteId: 1,
        'keywords': {
          'key1': 'val1',
          'key2': 'val2'
        }
      }
    }]
  }, {
    code: 'test-pb-banner',
    sizes: [[300, 250]],
    bids: [{
      bidder: 'sortable',
      params: {
        tagId: 'test-pb-banner',
        siteId: 1
      }
    }]
  }, {
    code: 'test-pb-sidebar',
    size: [[160, 600]],
    bids: [{
      bidder: 'sortable',
      params: {
        tagId: 'test-pb-sidebar',
        siteId: 1,
        'keywords': {
          'keyA': 'valA'
        }
      }
    }]
  }
]

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer: prebid@sortable.com
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• docs repo PR: Add documentation on Sortable adapter prebid.github.io#872

Other information

[jsnellbaker]

Hi @shannonAB,

Thanks for submitting this adapter. Overall, everything seems good. There is a unit test that should be reviewed as well as a potential update based on the feedback that was made in the related docs PR.

Once these items are addressed; we should be good to merge.

[jsnellbaker]

These checks are failing when I run gulp test locally. Could you look into a different approach than hard-coded values?

[jsnellbaker]

In lieu of the feedback provided on the docs PR (prebid/prebid.github.io#872); this may need to be updated.

[bgahagan]

Hi @jsnellbaker , I'll be helping out while Shannon is on vacation for the next few days. I've made the requested changes, let me know what you think.

[jsnellbaker]

Hi @bgahagan,

Thanks for making the updates. Those changes look good; however when I went to retest the adapter, I'm now getting a Bad Request response from the server.

The only error it's providing is unknown site. I believe this was working before, could you take a look?

Below is a copy of the request object:

{"id":"3d706ce860fa1e","imp":[{"id":"2185af434aa992","tagid":"test-pb-banner","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}]},"ext":{}}],"site":{"domain":"ap.localhost:9999","page":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","ref":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","publisher":{"id":"example.com"},"device":{"w":1680,"h":1050}}}

[bgahagan]

Hi @jsnellbaker , apologies, I when I updated the siteIds to be strings, I used the wrong value. Instead of example.com it should be prebid.example.com to get a test bid. I updated the examples.

[jsnellbaker]

Thanks for making the updates; the test deliveries are working fine now.

[jsnellbaker]

@bgahagan & @shannonAB
FYI #2837