Request options updated to send session cookie and avoid CORS preflight #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set withCredentials option to ensure cookies are sent with bid requests
mkendall07
requested changes
Jul 12, 2018
modules/playgroundxyzBidAdapter.js
Outdated
| @@ -44,8 +44,8 @@ export const spec = { | |||
| }; | |||
|
|
|||
| const options = { | |||
| contentType: 'application/json', | |||
| withCredentials: false | |||
| contentType: 'text/plain', | |||
There was a problem hiding this comment.
these are the default options in bidderFactory for a POST request. You can just remove the options property.
See: https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L260
|
Thanks @mkendall07 PR updated with options removed. Also added our usersync pixel - not sure if you prefer separate PRs for multiple small / unrelated changes? |
|
@mkendall07 just checking if there's anything else we need to action here? |
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
…ht (prebid#2840) * use content-type text/plain to avoid preflight CORS request set withCredentials option to ensure cookies are sent with bid requests * removed unnecessary options * reverted package-lock.json changes * added pxyz user sync pixel
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…ht (prebid#2840) * use content-type text/plain to avoid preflight CORS request set withCredentials option to ensure cookies are sent with bid requests * removed unnecessary options * reverted package-lock.json changes * added pxyz user sync pixel
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…ht (prebid#2840) * use content-type text/plain to avoid preflight CORS request set withCredentials option to ensure cookies are sent with bid requests * removed unnecessary options * reverted package-lock.json changes * added pxyz user sync pixel
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…ht (prebid#2840) * use content-type text/plain to avoid preflight CORS request set withCredentials option to ensure cookies are sent with bid requests * removed unnecessary options * reverted package-lock.json changes * added pxyz user sync pixel
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…ht (prebid#2840) * use content-type text/plain to avoid preflight CORS request set withCredentials option to ensure cookies are sent with bid requests * removed unnecessary options * reverted package-lock.json changes * added pxyz user sync pixel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
withCredentialsoption set to ensure cookies are sent with bid requests to our endpointcontentTypeset totext/plainto avoid the CORS preflight requestBe sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information