Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ajax timeout option #2864

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Disable ajax timeout option #2864

merged 2 commits into from
Jul 20, 2018

Conversation

jaiminpanchal27
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Disabled timeout temporarily to avoid xhr failed requests. #2648

mkendall07
mkendall07 requested changes Jul 18, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this an option inside setConfig

@jaiminpanchal27
Copy link
Collaborator Author

Added config

mkendall07
mkendall07 approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added needs docs needs 2nd review Core module updates require two approvals from the core team and removed in progress labels Jul 20, 2018
@jsnellbaker jsnellbaker requested a review from snapwich July 20, 2018 15:52
snapwich
snapwich approved these changes Jul 20, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 36cadef into master Jul 20, 2018
@mkendall07 mkendall07 changed the title Disable ajax timeout Disable ajax timeout option Jul 20, 2018
@mkendall07
Copy link
Member

@jaiminpanchal27
please open a docs PR

@jaiminpanchal27 jaiminpanchal27 mentioned this pull request Jul 20, 2018
Merged
@mkendall07 mkendall07 deleted the disable-timeout branch August 17, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

Labels
needs docs needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaiminpanchal27 @mkendall07 @snapwich @mjacobsonny @jsnellbaker