Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validated size array and added tests #2870

Merged
merged 1 commit into from
Jul 20, 2018
Merged

validated size array and added tests #2870

merged 1 commit into from
Jul 20, 2018

Conversation

brittanyzellman
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

function _isValidSize(size) {
  return (size.length === 2 && typeof size[0] === 'number' && typeof size[1] === 'number');
}

@jsnellbaker jsnellbaker self-requested a review July 20, 2018 16:01
@jsnellbaker jsnellbaker self-assigned this Jul 20, 2018
jsnellbaker
jsnellbaker approved these changes Jul 20, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 1b41bce into prebid:master Jul 20, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
@brittanyzellman @florevallatmrf
validated size array and added tests (prebid#2870)
cd19a8e
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
@brittanyzellman @StefanWallin
validated size array and added tests (prebid#2870)
2af7d4e
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@brittanyzellman
validated size array and added tests (prebid#2870)
0841240
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@brittanyzellman @AlessandroDG
validated size array and added tests (prebid#2870)
1d38668
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@brittanyzellman @AlessandroDG
validated size array and added tests (prebid#2870)
f6e4bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brittanyzellman @jsnellbaker