Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize sizes if only using adUnit.sizes #2875

Merged
merged 1 commit into from
Jul 25, 2018
Merged

normalize sizes if only using adUnit.sizes #2875

merged 1 commit into from
Jul 25, 2018

Conversation

snapwich
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

The change to normalize flat sizes (one-dimensional arrays) in #2738 only got applied if mediaType.banner.sizes was used. This fixes it so sizes are normalized even when only using the deprecated adUnit.sizes.

@jsnellbaker jsnellbaker self-requested a review July 23, 2018 13:58
@jsnellbaker jsnellbaker self-assigned this Jul 23, 2018
jsnellbaker
jsnellbaker approved these changes Jul 23, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Jul 23, 2018
@jsnellbaker jsnellbaker requested a review from mkendall07 July 23, 2018 14:37
mkendall07
mkendall07 approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case would be nice but LGTM. Thanks

@mkendall07 mkendall07 merged commit 2eca48e into prebid:master Jul 25, 2018
@robertrmartinez robertrmartinez deleted the normalized-sizes branch July 5, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

@jsnellbaker jsnellbaker

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snapwich @mkendall07 @jsnellbaker @mjacobsonny