Pr 0507 - support for dctr, currency and multi-size ad slots #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27th March 18: Merging Prebid Master into fork branch
…0507 Conflicts: modules/pubmaticBidAdapter.js test/spec/modules/pubmaticBidAdapter_spec.js
jsnellbaker
requested changes
Jul 25, 2018
There was a problem hiding this comment.
Hi @pm-manasi-moghe
These changes look okay. However when I was testing the merge to master by running our browserstack tests, I was seeing a consistent test failure in safari.
Below is a copy of the error details:
PubMatic adapter
implementation
Request formation
�[31m✗ �[39m�[31mRequest params multi size format object check�[39m
expected [] to have a length above 0 but got 0
AssertionError@webpack:///node_modules/assertion-error/index.js:74 <- test/test_index.js:20203:22
assert@webpack:///node_modules/chai/lib/chai/assertion.js:107 <- test/test_index.js:27769:31
assertAbove@webpack:///node_modules/chai/lib/chai/core/assertions.js:563 <- test/test_index.js:28362:18
webpack:///node_modules/chai/lib/chai/utils/addMethod.js:41 <- test/test_index.js:27356:30
webpack:///test/spec/modules/pubmaticBidAdapter_spec.js:306:88 <- test/test_index.js:104082:99
Could you take a look and see what may be the problem?
|
Hi @jsnellbaker, The test case looks ok, and works at my end. I have made a small change in it, so as to narrow down the cause of the failure at your end. Please let me know the status with the updated code. |
jsnellbaker
requested changes
Jul 26, 2018
modules/pubmaticBidAdapter.js
Outdated
| @@ -251,6 +262,14 @@ function _createImpressionObject(bid, conf) { | |||
| h: bid.params.height, | |||
| topframe: utils.inIframe() ? 0 : 1, | |||
| } | |||
| if (utils.isArray(sizes) && sizes.length > 1) { | |||
| sizes = sizes.splice(1); | |||
There was a problem hiding this comment.
I ran the updated unit test and the issue appeared to be the format object was getting an empty array.
I did some further debugging/experimenting and I believe the problem was due to this line of code.
When I added a proper range value as the 2nd param in the splice (like the following), the unit test completed successfully in Safari. I wasn't able to find anything definitive but it seemed like this was needed for the es5 shim of the splice to work. Can you implement this change?
var range = sizes.length - 1;
sizes = sizes.splice(1, range);
|
Made the required changes. |
jsnellbaker
approved these changes
Jul 27, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
…2887) * merging latest prebid master with video changes * fixed linting errors * moved data types to constants * merging changes for currency support and multisize support * replace hardcoded string 'pubmatic' with BIDDER_CODE * added code for dctr support * trim individual values in key-value * additional log messages added * fixed linting errors * fix test cases for dctr * rename paramter bidfloorcur to currency. * rename param bidfloorcur to currency * remove data_types constant from constants.json * changes to test cases for format object * change to splice method call as per review comments
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…2887) * merging latest prebid master with video changes * fixed linting errors * moved data types to constants * merging changes for currency support and multisize support * replace hardcoded string 'pubmatic' with BIDDER_CODE * added code for dctr support * trim individual values in key-value * additional log messages added * fixed linting errors * fix test cases for dctr * rename paramter bidfloorcur to currency. * rename param bidfloorcur to currency * remove data_types constant from constants.json * changes to test cases for format object * change to splice method call as per review comments
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…2887) * merging latest prebid master with video changes * fixed linting errors * moved data types to constants * merging changes for currency support and multisize support * replace hardcoded string 'pubmatic' with BIDDER_CODE * added code for dctr support * trim individual values in key-value * additional log messages added * fixed linting errors * fix test cases for dctr * rename paramter bidfloorcur to currency. * rename param bidfloorcur to currency * remove data_types constant from constants.json * changes to test cases for format object * change to splice method call as per review comments
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…2887) * merging latest prebid master with video changes * fixed linting errors * moved data types to constants * merging changes for currency support and multisize support * replace hardcoded string 'pubmatic' with BIDDER_CODE * added code for dctr support * trim individual values in key-value * additional log messages added * fixed linting errors * fix test cases for dctr * rename paramter bidfloorcur to currency. * rename param bidfloorcur to currency * remove data_types constant from constants.json * changes to test cases for format object * change to splice method call as per review comments
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…2887) * merging latest prebid master with video changes * fixed linting errors * moved data types to constants * merging changes for currency support and multisize support * replace hardcoded string 'pubmatic' with BIDDER_CODE * added code for dctr support * trim individual values in key-value * additional log messages added * fixed linting errors * fix test cases for dctr * rename paramter bidfloorcur to currency. * rename param bidfloorcur to currency * remove data_types constant from constants.json * changes to test cases for format object * change to splice method call as per review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
new parameter to specify currency and dctr prebid.github.io#890