Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref param sonobi #2891

Merged
merged 25 commits into from
Jul 26, 2018
Merged

Update ref param sonobi #2891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4f9d0a5
added vp param to trinity request
JonGoSonobi Apr 25, 2018
d23114c
added lib_name and lib_v to trinity
JonGoSonobi Apr 26, 2018
ff5fabf
return null from buildRequests if there is no keymakers
JonGoSonobi Apr 26, 2018
ac246fd
added test case for empty keymaker
JonGoSonobi Apr 26, 2018
ef36be2
only importing functions we need from utils
JonGoSonobi Apr 26, 2018
85c9994
changed window.pbjs.version to use the gulp repalced macro .version$
JonGoSonobi Apr 27, 2018
17bb578
Merge branch 'master' into APEX-1472-vp
JonGoSonobi Apr 27, 2018
82909d2
resolved merge conflicts
JonGoSonobi Apr 27, 2018
6c3e3a8
fixed issue where isEmpty was being called from old utils var. Change…
JonGoSonobi Apr 27, 2018
cf45587
fixed lint issue
JonGoSonobi Apr 27, 2018
fd54c1d
resolved merge conflict
JonGoSonobi May 3, 2018
8898bf8
fixed issue where sonobi getUserSync was throwing an error on timeout
JonGoSonobi May 3, 2018
271e16d
sonobi support referrer param
JonGoSonobi May 4, 2018
7090d44
Merge branch 'master' into APEX-1516-user-sync-timeout-err
JonGoSonobi May 4, 2018
2f45786
fixed unit test for testing the ref param on bid request
JonGoSonobi May 4, 2018
ffe0932
return null from buildRequests if there is no keymakers
JonGoSonobi Apr 26, 2018
e0d53c1
fixed issue where isEmpty was being called from old utils var. Change…
JonGoSonobi Apr 27, 2018
4d7079a
Add gdpr support
bansawbanchee May 17, 2018
a55446c
resolved merge conflict
JonGoSonobi May 23, 2018
9bf2803
Merge branch 'master' of https://github.com/prebid/Prebid.js
JonGoSonobi May 25, 2018
8f04800
Merge branch 'master' of github.com:sonobi/Prebid.js
JonGoSonobi May 25, 2018
5124c39
Merge branch 'master' of https://github.com/prebid/Prebid.js
JonGoSonobi May 30, 2018
3ac3da3
Merge branch 'master' of https://github.com/prebid/Prebid.js
JonGoSonobi Jun 6, 2018
6e662e7
Merge branch 'master' of https://github.com/prebid/Prebid.js
JonGoSonobi Jul 6, 2018
d21ef7e
update ref param to use href instead of host
bansawbanchee Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/sonobiBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const spec = {

const payload = {
'key_maker': JSON.stringify(data),
'ref': getTopWindowLocation().host,
'ref': getTopWindowLocation().href,
's': generateUUID(),
'pv': PAGEVIEW_ID,
'vp': _getPlatform(),
Expand Down Expand Up @@ -183,12 +183,12 @@ const _creative = (mediaType) => (sbi_dc, sbi_aid) => {
if (mediaType === 'video') {
return _videoCreative(sbi_dc, sbi_aid)
}
const src = 'https://' + sbi_dc + 'apex.go.sonobi.com/sbi.js?aid=' + sbi_aid + '&as=null' + '&ref=' + getTopWindowLocation().host;
const src = 'https://' + sbi_dc + 'apex.go.sonobi.com/sbi.js?aid=' + sbi_aid + '&as=null' + '&ref=' + getTopWindowLocation().href;
return '<script type="text/javascript" src="' + src + '"></script>';
};

function _videoCreative(sbi_dc, sbi_aid) {
return `https://${sbi_dc}apex.go.sonobi.com/vast.xml?vid=${sbi_aid}&ref=${getTopWindowLocation().host}`
return `https://${sbi_dc}apex.go.sonobi.com/vast.xml?vid=${sbi_aid}&ref=${getTopWindowLocation().href}`
}

function _getBidIdFromTrinityKey (key) {
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/sonobiBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ describe('SonobiBidAdapter', () => {
'url': 'https://apex.go.sonobi.com/trinity.json',
'withCredentials': true,
'data': {
'key_maker': '{"30b31c1838de1f":"1a2b3c4d5e6f1a2b3c4d|300x250,300x600|f=1.25","/7780971/sparks_prebid_LB|30b31c1838de1e":"300x250,300x600"}', 'ref': 'localhost:9876', 's': '2474372d-c0ff-4f46-aef4-a173058403d9', 'pv': 'c9cfc207-cd83-4a01-b591-8bb29389d4b0'
'key_maker': '{"30b31c1838de1f":"1a2b3c4d5e6f1a2b3c4d|300x250,300x600|f=1.25","/7780971/sparks_prebid_LB|30b31c1838de1e":"300x250,300x600"}', 'ref': 'http://localhost:9876/', 's': '2474372d-c0ff-4f46-aef4-a173058403d9', 'pv': 'c9cfc207-cd83-4a01-b591-8bb29389d4b0'
},
'bidderRequests': [
{
Expand Down Expand Up @@ -294,7 +294,7 @@ describe('SonobiBidAdapter', () => {
'cpm': 1.07,
'width': 300,
'height': 600,
'ad': '<script type="text/javascript" src="https://mco-1-apex.go.sonobi.com/sbi.js?aid=30292e432662bd5f86d90774b944b039&as=null&ref=localhost:9876"></script>',
'ad': '<script type="text/javascript" src="https://mco-1-apex.go.sonobi.com/sbi.js?aid=30292e432662bd5f86d90774b944b039&as=null&ref=http://localhost:9876/"></script>',
'ttl': 500,
'creativeId': '1234abcd',
'netRevenue': true,
Expand All @@ -306,7 +306,7 @@ describe('SonobiBidAdapter', () => {
'cpm': 1.25,
'width': 300,
'height': 250,
'ad': 'https://mco-1-apex.go.sonobi.com/vast.xml?vid=30292e432662bd5f86d90774b944b038&ref=localhost:9876',
'ad': 'https://mco-1-apex.go.sonobi.com/vast.xml?vid=30292e432662bd5f86d90774b944b038&ref=http://localhost:9876/',
'ttl': 500,
'creativeId': '30292e432662bd5f86d90774b944b038',
'netRevenue': true,
Expand Down