alter sonobi unit test to fix Edge test failure #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
requested changes
Jul 27, 2018
| @@ -318,6 +318,10 @@ describe('SonobiBidAdapter', () => { | |||
|
|
|||
| it('should map bidResponse to prebidResponse', () => { | |||
| const response = spec.interpretResponse(bidResponse, bidRequests); | |||
| response.forEach(resp => { | |||
| let regx = /http:\/\/localhost:9876\/.*?(?="|$)/ | |||
There was a problem hiding this comment.
I'm not sure hardcoded the port is a good way to prevent this error. I'm not sure but some process is generating the port (karma?) and we should probably use whatever it is assigning or figure out another way to prevent this test case failure.
There was a problem hiding this comment.
Like we discussed offline - I removed the port values from the unit tests. Please take another look when possible.
mkendall07
approved these changes
Jul 27, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* alter unit test to fix Edge test failure * removing port from unit test
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* alter unit test to fix Edge test failure * removing port from unit test
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* alter unit test to fix Edge test failure * removing port from unit test
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* alter unit test to fix Edge test failure * removing port from unit test
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* alter unit test to fix Edge test failure * removing port from unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
After #2891 was merged into master, Travis began reporting test failures in the sonobiBidAdapter_spec.js file for a unit test in Edge.
See link below:
https://travis-ci.org/prebid/Prebid.js/builds/408728279?utm_source=slack&utm_medium=notification
This PR fixes the error by standardizing the
refhref URL the unit test utilizes to just the domain (since random numbers are sometimes added in the url when running browserstack).