Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve custom download issues with freewheel-ssp bid adapter #2910

Merged
merged 69 commits into from
Aug 1, 2018
Merged

Solve custom download issues with freewheel-ssp bid adapter #2910

merged 69 commits into from
Aug 1, 2018

Conversation

guillaume-sticky
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [*] Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Rename the freewheelSSPBidAdapter files to freewheel-sspBidAdapter => match the bidder code to fix custom download at http://prebid.org/download.html

guillaume-sticky and others added 30 commits January 5, 2017 10:21
add stickyadsTV bidder adapter
632c8c1
init unit test file
a91ac2d
ad some unit tests
9e2d70e
fix unit test on ad format with parameters
9c92c3e
add some unit tests
7ed68e9
add unit tests on getBid method
88a45ac
add some test cases in unit tests
7d6bf3c
minor fix on component id tag.
affdd67
remove adapters-sticky.json test file
654a473
Merge remote-tracking branch 'Prebid/master'
3b0760e
use top most accessible window instead of window.top
8c0f143
Pass in the bid request in the createBid call.
fd877dc
use top most accessible window instead of window.top
09f7348
Merge remote-tracking branch 'Prebid/master'
28a36a6
add unit tests
90264e8
update unit tests
29453af
fix unit test.
b664ee1
fix CI build
57c31a1
Merge remote-tracking branch 'Prebid/master'
2915576
Merge remote-tracking branch 'Prebid/master'
c5c41be
add alias freewheel-ssp
475eee3
Merge remote-tracking branch 'Prebid/master'
71bfaa1
update unit tests on bidderCode value
410ee00
Merge branch 'master' into master
8f7c947
Merge remote-tracking branch 'Prebid/master'
1d7be59 
Conflicts:
	src/adapters/stickyadstv.js
	test/spec/adapters/stickyadstv_spec.js
fix component id values and add unit tests
b09dfdd
Merge remote-tracking branch 'Prebid/master'
d5e6d79
allws to use any outstream format.
d52df6f
fix ASLoader on futur outstream format versions
9ad2b7f
minor: fix code format.
427b45c
@guillaume-sticky
Merge commit '65c76ef80f68eb41962b98d388dde3259e3c1203'
2af4bad 
Conflicts:
	modules/freewheelSSPBidAdapter.js
	test/spec/modules/freewheelSSPBidAdapter_spec.js
@guillaume-sticky
Merge remote-tracking branch 'Prebid/master'
778c414
@guillaume-sticky
Merge remote-tracking branch 'Prebid/master'
ebd8e94
@guillaume-sticky
Merge remote-tracking branch 'Prebid/master'
113ad29
@guillaume-sticky
add vast parameters feature and GDPR params in VAST request
f62aab2
@guillaume-sticky
fix lint issues
0717715
@guillaume-sticky
Merge remote-tracking branch 'Prebid/master'
b332946
@guillaume-sticky
add gdpr parameter support on freewheelSSPBidAdapter
d7f57f4
@guillaume-sticky
use bidderrequest to read gdpr parameters and update unit tests
1ad8abd
@guillaume-sticky
fix lint errors
447785f
@guillaume-sticky
fix lint errors
37d95fc
@guillaume-sticky
fix typo and bidderRequest reference.
0238d92
@guillaume-sticky
fix bidderRequest reference.
2a18f58
@guillaume-sticky
add missing declaration for 'key' variable
de1de4b
@guillaume-sticky
Merge remote-tracking branch 'origin/master'
6e296d1
@guillaume-sticky
rename frewheel ssp bid adapter files to match the bidder code (fix c…
0684625 
…ustom download issues)
@mkendall07
Copy link
Member

You'll need to fix the import on the spec file. this is causing the build to fail

@mkendall07 mkendall07 self-assigned this Aug 1, 2018
mkendall07
mkendall07 approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkendall07 mkendall07 merged commit 96c39dd into prebid:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaume-sticky @mkendall07 @bretg