Pass Prebid version and update IDs in Criteo bidding adapter #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
approved these changes
Jul 31, 2018
|
can you please answer #2672 ? we are waiting more than two months now. |
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
…2913) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
…2913) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…2913) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…2913) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
…2913) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Passing the Prebid version and correct profile IDs to our bidding endpoint will allow us to better know our publishers' setup globally.
PS: the "adapter version" jumped from 8 to 11 because of some internal testing versions.