upgrade to gulp 4 #2930

jsnellbaker · 2018-08-02T15:20:58Z

Type of change

Build related changes
CI related changes

Description of change

Upgrade to gulp 4 to address vulnerabilities in gulp 3.x

To test - see updated notes in README.md file.

some additional references if needed:
https://www.joezimjs.com/javascript/complete-guide-upgrading-gulp-4/
https://github.com/gulpjs/gulp/blob/4.0/docs/API.md#gulptaskname-fn
https://github.com/gulpjs/gulp/blob/4.0/docs/getting-started.md (for gulp-cli transition)

mkendall07 · 2018-08-02T15:30:14Z

This pull request fixes 1 alert when merging a897464 into 47d3c3e - view on LGTM.com

fixed alerts:

1 for Unused variable

Comment posted by LGTM.com

mkendall07 · 2018-08-02T16:06:53Z

This pull request fixes 1 alert when merging 73a1df1 into a568fdf - view on LGTM.com

fixed alerts:

1 for Unused variable

Comment posted by LGTM.com

mkendall07 · 2018-08-07T16:57:23Z

This pull request fixes 1 alert when merging 73a1df1 into 752e234 - view on LGTM.com

fixed alerts:

1 for Unused variable

Comment posted by LGTM.com

mkendall07 · 2018-08-08T18:57:42Z

This pull request fixes 1 alert when merging 73a1df1 into a2c29b2 - view on LGTM.com

fixed alerts:

1 for Unused variable

Comment posted by LGTM.com

mkendall07

LGTM. tested on the download machine and everything worked correctly. Probably want to leave this for a bit to let other folks test out gulp 4.

mkendall07 · 2018-08-08T18:50:38Z

gulpfile.js

@@ -5,11 +5,11 @@ var argv = require('yargs').argv;
 var gulp = require('gulp');
 var gutil = require('gulp-util');
 var connect = require('gulp-connect');
-var path = require('path');
+// var path = require('path');


mkendall07 · 2018-08-08T18:51:16Z

gulpfile.js

+    .pipe(gulpClean());
+}
+
+function cleandocs() {


do we need this?

There are a number of gulp tasks that I'm not sure are still relevant, so I was keeping them in just in case. I can remove if it it's not needed.

let's drop this one. Let me know what others you don't think we need too.

Namely it's the tasks under the other tasks; specifically:

docs

bundleToStdout

bundle

serve-nw (appears to be related to e2etest, so likely will stay for now until that's reviewed)

run-tests

Based on discussion with @jaiminpanchal27 I removed:

docs

clean-docs

run-tests

jsnellbaker · 2018-08-13T19:51:16Z

In the recent commit - I added a new flag for the test function (notest). When enabled, it will immediately skip test function.

example usage
gulp serve --notest

This will help our development process, as we can iterate over the changes and not worry about manually disabling tests to get gulp serve to run.

mkendall07 · 2018-08-13T19:55:19Z

This pull request fixes 1 alert when merging 50aec49 into aa28600 - view on LGTM.com

fixed alerts:

1 for Unused variable

Comment posted by LGTM.com

jsnellbaker · 2018-08-17T17:37:54Z

Please don't merge immediately after final review - I need to coordinate some other changes with Jenkins when this goes out.

snapwich

LGTM

mkendall07 · 2018-08-21T19:44:11Z

This pull request fixes 1 alert when merging e7fd5bb into 11ec22a - view on LGTM.com

fixed alerts:

1 for Unused variable

Comment posted by LGTM.com

stale · 2018-09-04T20:20:56Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mkendall07 · 2018-09-05T12:21:42Z

This pull request fixes 1 alert when merging 624166c into 7945098 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

Comment posted by LGTM.com

glebglushtsov · 2018-09-13T18:37:58Z

FYI: run-tests gulp task has been removed but it seems you forgot to update npm scripts.

jsnellbaker · 2018-09-17T12:02:10Z

@glebglushtsov Thanks for the pointing this out. I'll fix that in a new PR.

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

@97

* Make size mapping mediaType aware (prebid#3134) * make sizeMapping mediaTypes aware * no sizeMapping if the only mediaType is not banner * better logging for size mapping and no auction when no bids * fix size mapping tests to ignore filter results (which are only for logging) * Making targeting keys configurable (prebid#3140) * moved NATIVE_KEYS to constants * Changed TARGETING_KEYS from array to an array - Now you can change key names - Made changes in code at auction.js and targeting.js to handle the TARGETING_KEYS object than array * fixed aauctionmanager test cases for dynamic targeting key names * fixed native test cases for dynamic targeting key names * fixed test cases of targeting for dynamic targeting key names * in-dev changes * replace old keys with new keys * fixed a typo * fixed a unit case in utils * updated convertTargetingsFromOldToNew in fixtures this will now replace partner specific keys as well as per config * removed a log * keep test case as it was * improved convertTargetingsFromOldToNew in fixtures * Capitalized key names in TARGETING_KEYS object; not values in object * using computed properties * using computed properties * fixed eslint suggestion * fixed eslint suggestions * keeping unit tests more compliant with Mocha * 4235 prebid endpoint return empty array instead of 204 when no bids returned (prebid#3136) * corrected user sync type * add alias pxyz add version to endpoint add validation for 204 bid response * add validation with serverResponse is undefined fix test for 204 (no bid response) * remove package lock * restore package-lock * update gulp 4 notes on README (prebid#3154) * Add teads bidder adapter (prebid#3135) * Add teads bidder adapter * Remove bidder code & tests arrow functions * Added the option to pass a deal id instead of a partnership id (prebid#3148) * increment Prebid version * Prebid 1.26.0 release * increment prebid version * implement find polyfill in unit test (prebid#3156) * InvibesBidAdapter - gdpr support (prebid#3151) * removed `cookieSyncDelay` from `config` since we have more configuration options now with the `userSync` object (prebid#3142) * Livewrapped bid and analytics adapter (prebid#3157) * Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * Adding appnexus debug via cookie/params (prebid#3152) * adding appnexus debug via cookie/params * removing nested object * added documentation link and removed useless conditional * fix lint error on documentation message * Add RSA validation to Criteo FastBid (prebid#3110) * Pass Prebid version to Criteo direct bidder * Update Criteo profile IDs * Add RSA verification to Criteo FastBid * Update package-lock with jsencrypt and crypto-js * Replacing all arrow functions in Mocha function calls * Update Adapter Version to 14 * Added support for user syncing pixel (prebid#3092) * Added Polymorph adapter * Cleaned up code * Updated var to let * Updated with mediaType * Updated tests * Fixed tests * Updated polymorph adapter to support cookie syncing and network key integration * Fixed parens for lint * Fixed a bug related to network_key approach * Fixed double negation warning * Updated tests for network_key * Added bidId as cache buster and updated tests * Fixed tests * Small bugfix and cleanup for Prebid Server OpenRTB code (prebid#3113) * change bid map to bid_id map and clean up openrtb in pbs * add src to bids in bid request when known * Revert "Adding appnexus debug via cookie/params" (prebid#3164) * Revert "Small bugfix and cleanup for Prebid Server OpenRTB code (prebid#3113)" This reverts commit a1f07e9. * Revert "Added support for user syncing pixel (prebid#3092)" This reverts commit 8fdf61d. * Revert "Add RSA validation to Criteo FastBid (prebid#3110)" This reverts commit e72e2dc. * Revert "Adding appnexus debug via cookie/params (prebid#3152)" This reverts commit 4797ea2. * add bid ttl to cache call (prebid#3163) * Render outstream safeframe (prebid#3159) * render outstream safeframe * move code to Renderer module * some more logic to move * Prebid 1.27.0 Release * increment Prebid version * rubiconBidAdapter - Checking FPD values are defined before toString() (prebid#3165) * rubiconBidAdapter - Checking FPD values are defined before toString() - Added two tests for this behavior * Removing unused variable * changed to compare against null added some null params to the tests to verify * Adding mediaType param to parseSizes in order to ALWAYS get the correct parse Size method correct. (prebid#3166) * PubMatic to support DigiTrust Id passing (prebid#3160) * in-dev changes * included config * Unit test cases for DigitrustId passing in PubMatic bid adapter * eslint fixes * removed a comment * replaced "() => {" with "() => {" * OpenX Adapter: Added support for pubcid (prebid#3158) * use version replace rather than package.json in widespace (prebid#3143) * Trafficroots Resubmit (prebid#3141) circleci is still failing, but I cannot find a workaround for this PR at the moment * Rubicon skip video request in mutlti format when video is not setup (prebid#3167) * Update rubiconBidAdapter.js * OpenXOutstream Bid Adapter (prebid#3153) * adds openxoutstreamadapter files * cleans up url, adds bidder config and version, removes unused code * updates template ad response * remove final unused custom param code * add openrtb to list of params again. * add payload back so we can read bidId * extra checks for cpm (pub_rev) * adds unit tests * adds unit tests * update md page * undo openx adapter space changes from autosave * undo openx adapter space changes from autosave * test cleanup * test cleanup * update md file * update example page params * remove sneaky console.log * return false * adds yieldmo to the md. remove useless docEl assignment * remove useless docEl assignments * move crid and adid to constants * fix test * remove another useless variable assignment caught by LGTM * changes CR_ID. moves tdoc to within if scope * updates crid on test * use more constants and use crid for lfid * remove superfluous trailing argument * adds viewport meta tag to header. removes unnecessary string interpolation. * move ad_id to a string * undo changes for pacakge-lock * fixes lfid to lfId, pID to pId * fixes lfid to lfId, pID to pId * remove rti:1 * adds openx maintainer email * improves additional data passed to the handler in AuctionInit and AuctionEnd events (prebid#3168) * removing cookieSet (prebid#3175) * removing cookieSet * removing blank line * not including src/cookie anymore * Removed deprecated priceType option (+tests) (prebid#3170) * Improve Digital adapter: set dealID based on buying type (prebid#3182) * Adding GDPR support * Always drop user syncs when available * Set dealID based on buying type * disabling tests that are failing in safari (prebid#3186) * Prebid 1.28.0 Release * Increment pre version * RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request prebid#11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * districtmDMX new adapter (prebid#2765) * adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * upgrade to gulp 4 (prebid#2930) * upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request prebid#17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

upgrade to gulp 4

a897464

jsnellbaker added the needs review label Aug 2, 2018

jsnellbaker requested review from mkendall07 and jaiminpanchal27 August 2, 2018 15:20

mkendall07 added the in progress label Aug 2, 2018

update circleci config

73a1df1

jsnellbaker mentioned this pull request Aug 3, 2018

investigate into upgrading gulp packages to 4.x #2906

Closed

mkendall07 assigned jaiminpanchal27 Aug 7, 2018

mkendall07 requested review from snapwich and harpere August 8, 2018 18:48

mkendall07 approved these changes Aug 8, 2018

View reviewed changes

mkendall07 added needs 2nd review Core module updates require two approvals from the core team LGTM labels Aug 8, 2018

jaiminpanchal27 approved these changes Aug 13, 2018

View reviewed changes

removed some tasks and added notest flag

50aec49

jsnellbaker unassigned jaiminpanchal27 Aug 16, 2018

jsnellbaker removed the in progress label Aug 17, 2018

snapwich approved these changes Aug 20, 2018

View reviewed changes

update lint dependency for test task

e7fd5bb

stale bot added the stale label Sep 4, 2018

jsnellbaker removed the stale label Sep 5, 2018

merge master branch and resolve conflicts

624166c

jsnellbaker merged commit ac207c5 into master Sep 5, 2018

jsnellbaker mentioned this pull request Sep 17, 2018

update test command in package.json scripts area #3098

Closed

1 task

ptomasroos pushed a commit to happypancake/Prebid.js that referenced this pull request Sep 25, 2018

upgrade to gulp 4 (prebid#2930)

da17680

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018

upgrade to gulp 4 (prebid#2930)

be83439

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

SublimeJeremy pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Oct 1, 2018

upgrade to gulp 4 (prebid#2930)

64d8c74

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Oct 17, 2018

upgrade to gulp 4 (prebid#2930)

afc8a40

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Oct 19, 2018

upgrade to gulp 4 (prebid#2930)

791f129

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019

upgrade to gulp 4 (prebid#2930)

fa4d64c

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019

upgrade to gulp 4 (prebid#2930)

0c826da

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019

upgrade to gulp 4 (prebid#2930)

d1ffe3b

* upgrade to gulp 4 * update circleci config * removed some tasks and added notest flag * update lint dependency for test task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade to gulp 4 #2930

upgrade to gulp 4 #2930

jsnellbaker commented Aug 2, 2018 •

edited

Loading

mkendall07 commented Aug 2, 2018

mkendall07 commented Aug 2, 2018

mkendall07 commented Aug 7, 2018

mkendall07 commented Aug 8, 2018

mkendall07 left a comment

mkendall07 Aug 8, 2018

mkendall07 Aug 8, 2018

jsnellbaker Aug 8, 2018

mkendall07 Aug 8, 2018 •

edited

Loading

jsnellbaker Aug 8, 2018

jsnellbaker Aug 13, 2018

jsnellbaker commented Aug 13, 2018

mkendall07 commented Aug 13, 2018

jsnellbaker commented Aug 17, 2018

snapwich left a comment

mkendall07 commented Aug 21, 2018

stale bot commented Sep 4, 2018

mkendall07 commented Sep 5, 2018

glebglushtsov commented Sep 13, 2018

jsnellbaker commented Sep 17, 2018

upgrade to gulp 4 #2930

upgrade to gulp 4 #2930

Conversation

jsnellbaker commented Aug 2, 2018 • edited Loading

Type of change

Description of change

mkendall07 commented Aug 2, 2018

mkendall07 commented Aug 2, 2018

mkendall07 commented Aug 7, 2018

mkendall07 commented Aug 8, 2018

mkendall07 left a comment

Choose a reason for hiding this comment

mkendall07 Aug 8, 2018

Choose a reason for hiding this comment

mkendall07 Aug 8, 2018

Choose a reason for hiding this comment

jsnellbaker Aug 8, 2018

Choose a reason for hiding this comment

mkendall07 Aug 8, 2018 • edited Loading

Choose a reason for hiding this comment

jsnellbaker Aug 8, 2018

Choose a reason for hiding this comment

jsnellbaker Aug 13, 2018

Choose a reason for hiding this comment

jsnellbaker commented Aug 13, 2018

mkendall07 commented Aug 13, 2018

jsnellbaker commented Aug 17, 2018

snapwich left a comment

Choose a reason for hiding this comment

mkendall07 commented Aug 21, 2018

stale bot commented Sep 4, 2018

mkendall07 commented Sep 5, 2018

glebglushtsov commented Sep 13, 2018

jsnellbaker commented Sep 17, 2018

jsnellbaker commented Aug 2, 2018 •

edited

Loading

mkendall07 Aug 8, 2018 •

edited

Loading