Replacing all arrow functions in Mocha function calls #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
# Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
jaiminpanchal27
approved these changes
Aug 31, 2018
mkendall07
approved these changes
Aug 31, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* replace arrow function in describe calls * replace arrow function in it calls * replace arrow function in before, beforeEach, after and afterEach calls * Merge remote-tracking branch 'upstream/master' # Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* replace arrow function in describe calls * replace arrow function in it calls * replace arrow function in before, beforeEach, after and afterEach calls * Merge remote-tracking branch 'upstream/master' # Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
* replace arrow function in describe calls * replace arrow function in it calls * replace arrow function in before, beforeEach, after and afterEach calls * Merge remote-tracking branch 'upstream/master' # Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* replace arrow function in describe calls * replace arrow function in it calls * replace arrow function in before, beforeEach, after and afterEach calls * Merge remote-tracking branch 'upstream/master' # Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* replace arrow function in describe calls * replace arrow function in it calls * replace arrow function in before, beforeEach, after and afterEach calls * Merge remote-tracking branch 'upstream/master' # Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* replace arrow function in describe calls * replace arrow function in it calls * replace arrow function in before, beforeEach, after and afterEach calls * Merge remote-tracking branch 'upstream/master' # Conflicts: # test/spec/modules/improvedigitalBidAdapter_spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Replacing all arrow functions in Mocha function calls (
describe,it,before,beforeEach,after,afterEach) to answer #2987.