Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33Across: add viewability #3084

Merged
merged 27 commits into from
Sep 19, 2018
Merged

33Across: add viewability #3084

merged 27 commits into from
Sep 19, 2018

Commits on Aug 3, 2018

  1. check gdpr in buildRequest

    @curlyblueeagle
    curlyblueeagle committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    60b6821 View commit details
    Browse the repository at this point in the history

  2. User sync based on whether gdpr applies or not

    @curlyblueeagle
    curlyblueeagle committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    888a1bd View commit details
    Browse the repository at this point in the history

  3. check if consent data exists during user sync

    @curlyblueeagle
    curlyblueeagle committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    59f8304 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. split user sync into further branches: 1) when gdpr does not apply 2)… 

    … when consent data is unavailable
    @curlyblueeagle
    curlyblueeagle committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    1096846 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Merge pull request #8 from 33Across/XCH-801_gdpr_compliance 

    XCH-801 GDPR Compliance
    @curlyblueeagle
    curlyblueeagle authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    6dfb54d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Merge remote-tracking branch 'upstream/master' 

    # Conflicts:
#	test/spec/modules/33acrossBidAdapter_spec.js
    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    c089d82 View commit details
    Browse the repository at this point in the history

  2. contribute viewability to ttxRequest

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    fc9e8c6 View commit details
    Browse the repository at this point in the history

  3. update tests

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    5a95872 View commit details
    Browse the repository at this point in the history

  4. remove window mock from tests

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    8aa0218 View commit details
    Browse the repository at this point in the history

  5. use local variables

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    7f75405 View commit details
    Browse the repository at this point in the history

  6. introduce ServerRequestBuilder

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    6aedf17 View commit details
    Browse the repository at this point in the history

  7. add withOptions() method to ServerRequestBuilder

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    9765718 View commit details
    Browse the repository at this point in the history

  8. add semicolons

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    88a6527 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #12 from 33Across/viewability 

    Viewability
    @glebglushtsov
    glebglushtsov authored Sep 12, 2018
    Configuration menu
    Copy the full SHA
    093062d View commit details
    Browse the repository at this point in the history

  10. sync up package-lock.json with upstream/master

    Gleb Glushtsov committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    ac0b586 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. stub window.top in tests

    Gleb Glushtsov committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    a9abbfb View commit details
    Browse the repository at this point in the history

  2. introduce getTopWindowSize() for test purpose

    Gleb Glushtsov committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    f701fb9 View commit details
    Browse the repository at this point in the history

  3. reformat code

    Gleb Glushtsov committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    059437b View commit details
    Browse the repository at this point in the history

  4. add withSite() method to TtxRequestBuilder 

    add withSite() method to TtxRequestBuilder
    Gleb Glushtsov committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    90e5bed View commit details
    Browse the repository at this point in the history

  5. Merge pull request #14 from 33Across/viewability 

    Viewability
    @glebglushtsov
    glebglushtsov authored Sep 13, 2018
    Configuration menu
    Copy the full SHA
    9660102 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Merge remote-tracking branch 'upstream/master'

    Gleb Glushtsov committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    832e1d1 View commit details
    Browse the repository at this point in the history

  2. add isIframe() and _isViewabilityMeasurable()

    Gleb Glushtsov committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    f26b47a View commit details
    Browse the repository at this point in the history

  3. handle NON_MEASURABLE viewability in nested iframes

    Gleb Glushtsov committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    8f34683 View commit details
    Browse the repository at this point in the history

  4. consider page visibility, stub utils functions getWindowTop() and get… 

    …WindowSelf()
    Gleb Glushtsov committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    07f4933 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #15 from 33Across/viewability 

    Viewability
    @glebglushtsov
    glebglushtsov authored Sep 14, 2018
    Configuration menu
    Copy the full SHA
    525684b View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. contribute viewability as 0 for inactive tab

    Gleb Glushtsov committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    8507272 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #16 from 33Across/viewability 

    contribute viewability as 0 for inactive tab
    @glebglushtsov
    glebglushtsov authored Sep 17, 2018
    Configuration menu
    Copy the full SHA
    d502156 View commit details
    Browse the repository at this point in the history