Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Video Renderer #3104

Merged
merged 20 commits into from
Sep 28, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions modules/zedoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ import * as utils from 'src/utils';
import { registerBidder } from 'src/adapters/bidderFactory';
import { BANNER, VIDEO } from 'src/mediaTypes';
import find from 'core-js/library/fn/array/find';
import { Renderer } from 'src/Renderer';

const BIDDER_CODE = 'zedo';
const URL = '//z2.zedo.com/asw/fmh.json';
const SECURE_URL = '//z2.zedo.com/asw/fmh.json';
const SECURE_URL = '//saxp.zedo.com/asw/fmh.json';
const DIM_TYPE = {
'7': 'display',
'9': 'display',
Expand Down Expand Up @@ -153,6 +154,8 @@ function newBid(serverBid, creativeBid, bidderRequest) {
const bid = {
requestId: serverBid.slotId,
creativeId: creativeBid.adId,
network: serverBid.network,
adType: creativeBid.creativeDetails.type,
dealId: 99999999,
currency: 'USD',
netRevenue: true,
Expand All @@ -167,12 +170,21 @@ function newBid(serverBid, creativeBid, bidderRequest) {
cpm: (parseInt(creativeBid.cpm) * 0.65) / 1000000,
ttl: 3600
});
const rendererOptions = utils.deepAccess(
bidderRequest,
'renderer.options'
);
let rendererUrl = utils.getTopWindowLocation().protocol === 'http:' ? 'http://c14.zedo.com/gecko/beta/fmpbgt.min.js' : 'https://ss3.zedo.com/gecko/beta/fmpbgt.min.js';
Object.assign(bid, {
adResponse: serverBid,
renderer: getRenderer(bid.adUnitCode, serverBid.slotId, rendererUrl, rendererOptions)
});
} else {
Object.assign(bid, {
width: creativeBid.width,
height: creativeBid.height,
cpm: (parseInt(creativeBid.cpm) * 0.6) / 1000000,
ad: creativeBid.creativeDetails.adContent
ad: creativeBid.creativeDetails.adContent,
});
}

Expand All @@ -197,6 +209,39 @@ function getSizes(requestSizes) {
return [width, height];
}

function getRenderer(adUnitCode, rendererId, rendererUrl, rendererOptions = {}) {
const renderer = Renderer.install({
id: rendererId,
url: rendererUrl,
config: rendererOptions,
loaded: false,
});

try {
renderer.setRender(videoRenderer);
} catch (err) {
utils.logWarn('Prebid Error calling setRender on renderer', err);
}

renderer.setEventHandlers({
impression: () => utils.logMessage('ZEDO video impression'),
loaded: () => utils.logMessage('ZEDO video loaded'),
ended: () => {
utils.logMessage('ZEDO renderer video ended');
document.querySelector(`#${adUnitCode}`).style.display = 'none';
}
});
return renderer;
}

function videoRenderer(bid) {
// push to render queue
bid.renderer.push(() => {
var rndr = new ZdPBTag(bid.adUnitCode, bid.network, bid.width, bid.height, bid.adType, bid.vastXml);
rndr.renderAd();
});
}

function parseMediaType(creativeBid) {
const adType = creativeBid.creativeDetails.type;
if (adType === 'VAST') {
Expand Down
8 changes: 6 additions & 2 deletions test/spec/modules/zedoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('The ZEDO bidding adapter', function () {
},
];
const request = spec.buildRequests(bidRequests, bidderRequest);
expect(request.url).to.match(/^\/\/z2.zedo.com\/asw\/fmh.json/);
expect(request.url).to.match(/^\/\/saxp.zedo.com\/asw\/fmh.json/);
expect(request.method).to.equal('GET');
const zedoRequest = request.data;
expect(zedoRequest).to.equal('g={"placements":[{"network":20,"channel":0,"width":300,"height":200,"dimension":10,"version":"$prebid.version$","keyword":"","transactionId":"12345667","renderers":[{"name":"display"}]}]}');
Expand All @@ -68,7 +68,7 @@ describe('The ZEDO bidding adapter', function () {
},
];
const request = spec.buildRequests(bidRequests, bidderRequest);
expect(request.url).to.match(/^\/\/z2.zedo.com\/asw\/fmh.json/);
expect(request.url).to.match(/^\/\/saxp.zedo.com\/asw\/fmh.json/);
expect(request.method).to.equal('GET');
const zedoRequest = request.data;
expect(zedoRequest).to.equal('g={"placements":[{"network":20,"channel":0,"width":640,"height":480,"dimension":85,"version":"$prebid.version$","keyword":"","transactionId":"12345667","renderers":[{"name":"Inarticle"}]}]}');
Expand Down Expand Up @@ -234,14 +234,18 @@ describe('The ZEDO bidding adapter', function () {
},
}]
};

const bids = spec.interpretResponse(response, request);
expect(bids).to.have.lengthOf(1);
expect(bids[0].requestId).to.equal('ad1d762');
expect(bids[0].cpm).to.equal(0.78);
expect(bids[0].width).to.equal('640');
expect(bids[0].height).to.equal('480');
expect(bids[0].adType).to.equal('VAST');
expect(bids[0].vastXml).to.not.equal('');
expect(bids[0].ad).to.be.an('undefined');
expect(bids[0].renderer).not.to.be.an('undefined');
bids[0].renderer.render(bids[0]);
});
});

Expand Down