Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding appnexus debug via cookie/params #3152

Merged
merged 4 commits into from
Oct 9, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions modules/appnexusBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const VIDEO_TARGETING = ['id', 'mimes', 'minduration', 'maxduration',
'startdelay', 'skippable', 'playback_method', 'frameworks'];
const USER_PARAMS = ['age', 'external_uid', 'segments', 'gender', 'dnt', 'language'];
const APP_DEVICE_PARAMS = ['geo', 'device_id']; // appid is collected separately
const DEBUG_PARAMS = ['enabled', 'dongle', 'member_id', 'debug_timeout'];
const NATIVE_MAPPING = {
body: 'description',
cta: 'ctatext',
Expand Down Expand Up @@ -77,6 +78,30 @@ export const spec = {
};
}

let debugObj = {};
let debugObjParams = {};
const debugCookieName = 'apn_prebid_debug';
const debugCookie = getCookie(debugCookieName) || false;
aneuway2 marked this conversation as resolved.
Show resolved Hide resolved

if (debugCookie) {
try {
debugObjParams['debug'] = JSON.parse(debugCookie);
} catch (e) {
utils.logError('AppNexus Debug Auction Cookie Error:\n\n' + e);
}
} else {
debugObjParams = find(bidRequests, hasDebug);
}

if (debugObjParams && debugObjParams.debug) {
Object.keys(debugObjParams.debug)
.filter(param => includes(DEBUG_PARAMS, param))
.forEach(param => {
debugObj['debug'] = debugObj['debug'] || {};
debugObj.debug[param] = debugObjParams.debug[param]
});
}
aneuway2 marked this conversation as resolved.
Show resolved Hide resolved

const memberIdBid = find(bidRequests, hasMemberId);
const member = memberIdBid ? parseInt(memberIdBid.params.member, 10) : 0;

Expand All @@ -99,6 +124,11 @@ export const spec = {
payload.app = appIdObj;
}

if (debugObj && debugObj.debug) {
payload.debug = debugObj.debug;
utils.logInfo('AppNexus Debug Auction Settings:\n\n' + JSON.stringify(debugObj.debug, null, 4));
}

if (bidderRequest && bidderRequest.gdprConsent) {
// note - objects for impbus use underscore instead of camelCase
payload.gdpr_consent = {
Expand Down Expand Up @@ -154,6 +184,21 @@ export const spec = {
}
});
}

if (serverResponse.debug && serverResponse.debug.debug_info) {
let debugHeader = 'AppNexus Debug Auction for Prebid\n\n'
let debugText = debugHeader + serverResponse.debug.debug_info
debugText = debugText
.replace(/(<td>|<th>)/gm, '\t') // Tables
.replace(/(<\/td>|<\/th>)/gm, '\n') // Tables
.replace(/^<br>/gm, '') // Remove leading <br>
.replace(/(<br>\n|<br>)/gm, '\n') // <br>
.replace(/<h1>(.*)<\/h1>/gm, '\n\n===== $1 =====\n\n') // Header H1
.replace(/<h[2-6]>(.*)<\/h[2-6]>/gm, '\n\n*** $1 ***\n\n') // Headers
.replace(/(<([^>]+)>)/igm, ''); // Remove any other tags
utils.logMessage(debugText);
}

return bids;
},

Expand Down Expand Up @@ -429,6 +474,15 @@ function hasAppId(bid) {
return !!bid.params.app
}

function hasDebug(bid) {
return !!bid.debug
}

function getCookie(name) {
let m = window.document.cookie.match('(^|;)\\s*' + name + '\\s*=\\s*([^;]*)\\s*(;|$)');
return m ? decodeURIComponent(m[2]) : null;
}

function getRtbBid(tag) {
return tag && tag.ads && tag.ads.length && find(tag.ads, ad => ad.rtb);
}
Expand Down
28 changes: 27 additions & 1 deletion test/spec/modules/appnexusBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,33 @@ describe('AppNexusAdapter', function () {
rd_stk: bidderRequest.refererInfo.stack.map((url) => encodeURIComponent(url)).join(',')
});
});
})

it('adds debug auction settings to payload', () => {
let debugRequest = Object.assign({},
bidRequests[0],
{
params: {
placementId: '10433394'
},
debug: {
enabled: true,
dongle: 'QWERTY',
member_id: 958,
debug_timeout: 1000
}
}
);
const request = spec.buildRequests([debugRequest]);
const payload = JSON.parse(request.data);
expect(payload.debug).to.exist;
expect(payload.debug).to.deep.equal({
enabled: true,
dongle: 'QWERTY',
member_id: 958,
debug_timeout: 1000
});
});
});

describe('interpretResponse', function () {
let response = {
Expand Down