only set mediaTypes.banner.sizes from sizes if mediaTypes doesn't exist. #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idettman
added
needs review
needs 2nd review
nanek
reviewed
Nov 14, 2018
| @@ -65,22 +65,20 @@ export function resolveStatus({labels = [], labelAll = false, activeLabels = []} | |||
| let maps = evaluateSizeConfig(configs); | |||
|
|
|||
| if (!isPlainObject(mediaTypes)) { | |||
| mediaTypes = {}; | |||
| // add support for deprecated adUnit.sizes by creating correct banner mediaTypes if they don't already exist | |||
| if (sizes) { | |||
There was a problem hiding this comment.
Should this check if mediaTypes already exists, as stated in description?
I'm testing this fix out, but I still see mediaTypes.banner.sizes set when I'm only configuring an instream video mediaType.
There was a problem hiding this comment.
My mistake, I was testing a prebid version without this fix. With the fix, I can confirm that it is working as expected and no longer setting mediaType.banner if only a video unit.
Thanks for the fix!
mike-chowla
removed
the
needs 2nd review
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #3269. The issue is when
mediaTypes.video.playerSizeis set thenadUnits.sizesis set here. Since sizeMapping still supportsadUnit.sizesit will setadUnit.mediaTypes.banner.sizesif it doesn't already exist, which is a bug ifadUnit.sizeswas set from the video sizes. So to fix this, this pull-request only setsadUnit.mediaTypes.banner.sizesfromadUnit.sizesifadUnit.mediaTypesdoesn't exist.