Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new NO_BID event and "no bids" available from auction #3286

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

snapwich
Copy link
Collaborator

@snapwich snapwich commented Nov 9, 2018

Type of change

  • Bugfix
  • Feature

Description of change

Added the a new event NO_BID which is fired for analytics and anything else interested in bidders not bidding. Since no bid is created when not bidding, the NO_BID event sends the bid request that the bidder was notified of but decided not to respond to. The auction also keeps track of these bid requests that resulted in no bid and makes them available through a new API call pbjs.getNoBids(), this is primarily for the updated debug snippet in prebid/prebid.github.io#1030

Also added a fix for a potential bug with the new done callback refactoring (in #3024). The updated logic was relying on counting which can be problematic (for instance, if one bidder calls done more than once that could potentially end the auction early). New logic only ends auction if done has been heard from each bidder with a bidderRequest.

Other information

fixes #2640 and is a replacement solution for #3022

@snapwich snapwich changed the title new no bid event and no bids available from auction new NO_BID event and "no bids" available from auction Nov 9, 2018
@stale
Copy link

stale bot commented Nov 26, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 26, 2018
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jaiminpanchal27 jaiminpanchal27 added LGTM needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Nov 27, 2018
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman removed the needs 2nd review Core module updates require two approvals from the core team label Nov 27, 2018
@mkendall07
Copy link
Member

sorry for the delay. Will get to this PR this week.

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we just need a docs PR for the new method?

@GLStephen
Copy link
Collaborator

@mkendall07 @snapwich hey we're waiting on this for an update to our analytics adapter, can I contribute to the docs and help with getting this moved along or is it in progress?

@mkendall07
Copy link
Member

@GLStephen nothing on my end in progress - feel free to work on it. Thanks!

@snapwich
Copy link
Collaborator Author

Sorry, thought I had already documented everything. The snippet has been updated but I guess we should add documentation for the new API method; just created a new pull-request for that feature.

@GLStephen
Copy link
Collaborator

@snapwich @mkendall07 looks like docs are done, do you think this can make it into the next release?

@mkendall07 mkendall07 merged commit 65afce6 into master Dec 17, 2018
@mkendall07 mkendall07 deleted the no-bids branch December 17, 2018 14:26
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New prebid version doesn't show all bids in the console
6 participants