Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial version of ozone adapter for review #3307

Merged
merged 5 commits into from
Dec 4, 2018
Merged

initial version of ozone adapter for review #3307

merged 5 commits into from
Dec 4, 2018

Conversation

afsheenb
Copy link
Contributor

Type of change

  • [X ] New bidder adapter

Description of change

Submitting the first version of the Ozone Project's Prebid.js adapter for review and comments.

  • test parameters for validating bids
 bidder: 'ozone',
                        params: {
                            publisherId: 'OZONENUK0001', /* an ID to identify the publisher account  - required */
                            siteId: '4204204201', /* An ID used to identify a site within a publisher account - required */
                            placementId: '0420420421', /* an ID used to identify the piece of inventory - required - for appnexus test use 13144370. */
                            customData: {"key1": "value1", "key2": "value2}, /* optional JSON placeholder for passing publisher key-values for targeting. */
                            ozoneData: {"key1": "value1", "key2": "value2"}, /* optional JSON placeholder for for passing ozone project key-values for targeting. */
                            lotameData: {"key1": "value1", "key2": "value2} /* optional JSON placeholder for passing Lotame DMP data */
                        }

@AskRupert-DM
Copy link
Contributor

@bretg - do you know if this will get assigned to someone to review automatically ?

@mkendall07
Copy link
Member

@hhhjort fyi

jaiminpanchal27
jaiminpanchal27 requested changes Nov 27, 2018
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afsheenb See comments. Also please add unit tests

modules/ozoneBidAdapter.js Outdated
*/
isBidRequestValid(bid) {
if (!(bid.params.hasOwnProperty('placementId'))) {
console.log('OZONE BID ADAPTER VALIDATION FAILED : missing placementId : siteId, placementId and publisherId are REQUIRED');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use utils.logInfo here and all other places where console.log is used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

modules/ozoneBidAdapter.js Outdated

const BIDDER_CODE = 'ozone';

var OZONEURI = 'https://elb.the-ozone-project.com/openrtb2/auction';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here const can be used. Also use let/const wherever applicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

modules/ozoneBidAdapter.js Outdated

export const spec = {
code: BIDDER_CODE,
supportedFormat: ['banner'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

banner is default. No need to add supportedFormat if you only support banner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afsheenb
Copy link
Contributor Author

Thanks for the review @jaiminpanchal27, we've updated the adapter with your recommended changes.

@jaiminpanchal27 jaiminpanchal27 merged commit 96df52f into prebid:master Dec 4, 2018
@afsheenb afsheenb mentioned this pull request Jan 24, 2019
Merged
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@afsheenb
initial version of ozone adapter for review (prebid#3307)
e848cab 
* initial version of ozone adapter for review

* updates made per prebid.org feedback

* Added a new line as failed prebid.org automated test

* Unit Tests for Ozone Adaptor

* updated URIs to include https protocol which failed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
needs unit tests needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afsheenb @AskRupert-DM @mkendall07 @jaiminpanchal27