use custom bind where non-standard mootools bind could cause issues #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
package-lock needs to be resolved |
snapwich
force-pushed
the
mootools-bind-fix
branch
from
dda4384 to
46e9541
Compare
snapwich
added
needs 2nd review
|
updated |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
snapwich/fun-hooks#1 highlighted an issue where MooTools with the compatibility layer being present on the page can cause non-standard behavior with
Function.prototype.bindNot really a bug in Prebid.js, but probably worth avoiding if we can (as it could still cause issues with Prebid.js installs). This pull-request updates incompatible usages of
bindto use our customutils.bindwhich will be eitherFunction.prototype.bindif the incompatible MooToolsbindis not detected, or our custom implementation of thebindfunction if it is detected. Also updatesfun-hooksdependency to use version with similar fix.